From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Layton Subject: [PATCH v4 06/17] vfs: turn "empty" arg in getname_flags into a bool Date: Thu, 26 Jul 2012 07:55:09 -0400 Message-ID: <1343303720-11199-7-git-send-email-jlayton@redhat.com> References: <1343303720-11199-1-git-send-email-jlayton@redhat.com> Cc: linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, michael.brantley@deshaw.com, hch@infradead.org, miklos@szeredi.hu, pstaubach@exagrid.com To: viro@ZenIV.linux.org.uk Return-path: In-Reply-To: <1343303720-11199-1-git-send-email-jlayton@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org ...it's just used as a flag. Signed-off-by: Jeff Layton --- fs/namei.c | 4 ++-- fs/stat.c | 2 +- include/linux/fs.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/namei.c b/fs/namei.c index 244ee8b..6563077 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -117,7 +117,7 @@ * POSIX.1 2.4: an empty pathname is invalid (ENOENT). * PATH_MAX includes the nul terminator --RR. */ -char *getname_flags(const char __user *filename, int flags, int *empty) +char *getname_flags(const char __user *filename, int flags, bool *empty) { char *result = __getname(), *err; int len; @@ -133,7 +133,7 @@ char *getname_flags(const char __user *filename, int flags, int *empty) /* The empty path is special. */ if (unlikely(!len)) { if (empty) - *empty = 1; + *empty = true; err = ERR_PTR(-ENOENT); if (!(flags & LOOKUP_EMPTY)) goto error; diff --git a/fs/stat.c b/fs/stat.c index c9d88f7..4f8b6bc 100644 --- a/fs/stat.c +++ b/fs/stat.c @@ -306,7 +306,7 @@ SYSCALL_DEFINE4(readlinkat, int, dfd, const char __user *, pathname, { struct path path; int error; - int empty = 0; + bool empty = false; char *name; unsigned int try = 0; unsigned int lookup_flags = LOOKUP_EMPTY; diff --git a/include/linux/fs.h b/include/linux/fs.h index 00db714..386d016 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -2062,7 +2062,7 @@ extern struct file *file_open_root(struct dentry *, struct vfsmount *, const char *, int); extern struct file * dentry_open(const struct path *, int, const struct cred *); extern int filp_close(struct file *, fl_owner_t id); -extern char *getname_flags(const char __user *, int, int *); +extern char *getname_flags(const char __user *, int, bool *); extern char * getname(const char __user *); enum { FILE_CREATED = 1, -- 1.7.11.2