From: eshink@gmail.com
To: Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Alex Kelly <eshink@gmail.com>, Alex Kelly <alex.page.kelly@gmail.com>
Subject: [PATCH 3/4] fs: Clean up some artifacts in coredump.c
Date: Sun, 5 Aug 2012 01:28:19 -0700 [thread overview]
Message-ID: <1344155300-10432-3-git-send-email-eshink@gmail.com> (raw)
In-Reply-To: <1344155300-10432-1-git-send-email-eshink@gmail.com>
From: Alex Kelly <eshink@gmail.com>
Specifically, some whitespace got carried over from the move that
shouldn't have, and there were some comment style issues in the original
code that are now fixed
Signed-off-by: Alex Kelly <alex.page.kelly@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
---
fs/coredump.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/fs/coredump.c b/fs/coredump.c
index 34c9236..7f75060 100644
--- a/fs/coredump.c
+++ b/fs/coredump.c
@@ -70,7 +70,6 @@ static int zap_process(struct task_struct *start, int exit_code)
return nr;
}
-
/*
* Core dumping helper functions. These are the only things you should
* do on a core-file: use only these functions to write out all the
@@ -195,8 +194,10 @@ static int format_corename(struct core_name *cn, long signr)
if (!cn->corename)
return -ENOMEM;
- /* Repeat as long as we have more pattern to process and more output
- space */
+ /*
+ * Repeat as long as we have more pattern to process and more output
+ * space.
+ */
while (*pat_ptr) {
if (*pat_ptr != '%') {
if (*pat_ptr == 0)
@@ -471,7 +472,6 @@ static int umh_pipe_setup(struct subprocess_info *info, struct cred *new)
return 0;
}
-
void do_coredump(long signr, int exit_code, struct pt_regs *regs)
{
struct core_state core_state;
--
1.7.11.2
next prev parent reply other threads:[~2012-08-05 8:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-03 21:03 [PATCH 1/2] Moved core dump functionality into its own file Alex Kelly
2012-08-03 21:03 ` [PATCH 2/2] Made core dump functionality optional Alex Kelly
2012-08-04 6:43 ` [PATCH 1/2] Moved core dump functionality into its own file Ingo Molnar
2012-08-05 8:28 ` [PATCH 1/4] fs: Move " eshink
2012-08-05 8:28 ` [PATCH 2/4] fs: Make core dump functionality optional eshink
2012-08-05 8:28 ` eshink [this message]
2012-08-05 8:28 ` [PATCH 4/4] fs: Update coredump-related headers eshink
2012-08-05 11:18 ` [PATCHv3 1/4] fs: Move core dump functionality into its own file Alex Kelly
2012-08-05 11:18 ` [PATCHv3 2/4] fs: Make core dump functionality optional Alex Kelly
2012-08-05 11:18 ` [PATCHv3 3/4] fs: Clean up some artifacts in coredump.c Alex Kelly
2012-08-05 11:18 ` [PATCHv3 4/4] fs: Update coredump-related headers Alex Kelly
2012-08-05 18:39 ` [NAK] Re: [PATCHv3 1/4] fs: Move core dump functionality into its own file Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1344155300-10432-3-git-send-email-eshink@gmail.com \
--to=eshink@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alex.page.kelly@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).