From: Artem Bityutskiy <dedekind1@gmail.com>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: Marco Stornelli <marco.stornelli@gmail.com>,
bhalevy@tonian.com, jack@suse.cz,
Andrew Morton <akpm@linux-foundation.org>,
adilger.kernel@dilger.ca, tytso@mit.edu,
hirofumi@mail.parknet.co.jp, mikulas@artax.karlin.mff.cuni.cz,
Al Viro <viro@ZenIV.linux.org.uk>,
hch@infradead.org, dushistov@mail.ru, osd-dev@open-osd.org,
Linux Kernel <linux-kernel@vger.kernel.org>,
linux-ext4@vger.kernel.org,
Linux FS Devel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 2/8] exofs: remove lock/unlock super
Date: Thu, 16 Aug 2012 16:10:11 +0300 [thread overview]
Message-ID: <1345122611.3393.225.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <502CE840.4060802@panasas.com>
[-- Attachment #1: Type: text/plain, Size: 813 bytes --]
On Thu, 2012-08-16 at 15:32 +0300, Boaz Harrosh wrote:
> On 08/16/2012 03:20 PM, Artem Bityutskiy wrote:
>
> > On Thu, 2012-08-16 at 12:00 +0200, Marco Stornelli wrote:
> >> From: Marco Stornelli <marco.stornelli@gmail.com>
> >>
> >> Remove lock and unlock super operation.
> >>
> >> Signed-off-by: Marco Stornelli <marco.stornelli@gmail.com>
> >
> > Acked-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> >
>
>
> Are you sure? It used to be that exofs_sync_fs() could be called
> concurrently.
>
> What about two "bash -c sync" calls or a sync and an unmount
> in parallel. anything protecting that?
>
> If so then sure, but please let me test first.
Umm, actually we will probably end up writing the same twice without the
lock.
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-08-16 13:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-16 10:00 [PATCH 2/8] exofs: remove lock/unlock super Marco Stornelli
2012-08-16 12:20 ` Artem Bityutskiy
2012-08-16 12:32 ` Boaz Harrosh
2012-08-16 13:10 ` Artem Bityutskiy [this message]
2012-08-16 13:15 ` Boaz Harrosh
2012-08-16 13:23 ` Boaz Harrosh
2012-08-16 13:30 ` Artem Bityutskiy
2012-08-16 13:29 ` Boaz Harrosh
2012-08-16 16:09 ` Marco Stornelli
2012-08-16 13:23 ` Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345122611.3393.225.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=bhalevy@tonian.com \
--cc=bharrosh@panasas.com \
--cc=dushistov@mail.ru \
--cc=hch@infradead.org \
--cc=hirofumi@mail.parknet.co.jp \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marco.stornelli@gmail.com \
--cc=mikulas@artax.karlin.mff.cuni.cz \
--cc=osd-dev@open-osd.org \
--cc=tytso@mit.edu \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).