From: David Woodhouse <dwmw2@infradead.org>
To: Nathan Zimmer <nzimmer@sgi.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
adobriyan@gmail.com
Subject: Re: [RFC] Move kfree outside pde_unload_lock
Date: Wed, 22 Aug 2012 10:24:04 +0100 [thread overview]
Message-ID: <1345627444.21476.54.camel@shinybook.infradead.org> (raw)
In-Reply-To: <20120821205454.GA7772@gulag1.americas.sgi.com>
[-- Attachment #1: Type: text/plain, Size: 195 bytes --]
On Tue, 2012-08-21 at 15:54 -0500, Nathan Zimmer wrote:
> + if (pdeo) {
> + kfree(pdeo);
> + }
Just make it unconditional. kfree(NULL) is a no-op.
--
dwmw2
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 6171 bytes --]
prev parent reply other threads:[~2012-08-22 9:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-21 20:54 [RFC] Move kfree outside pde_unload_lock Nathan Zimmer
2012-08-21 22:03 ` Alexey Dobriyan
2012-08-22 9:24 ` David Woodhouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345627444.21476.54.camel@shinybook.infradead.org \
--to=dwmw2@infradead.org \
--cc=adobriyan@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nzimmer@sgi.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).