linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: viro-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org
Cc: linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	michael.brantley-Iq/kdjr4a97QT0dZR+AlfA@public.gmane.org,
	hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
	miklos-sUDqSbJrdHQHWmgEVkV9KA@public.gmane.org,
	pstaubach-83r9SdEf25FBDgjK7y7TUQ@public.gmane.org
Subject: [PATCH v6 09/20] vfs: add a reval argument to user_path_parent
Date: Fri,  7 Sep 2012 10:18:16 -0400	[thread overview]
Message-ID: <1347027507-20956-10-git-send-email-jlayton@redhat.com> (raw)
In-Reply-To: <1347027507-20956-1-git-send-email-jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

...so we can tell it when to set LOOKUP_REVAL.

Signed-off-by: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
---
 fs/namei.c | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/fs/namei.c b/fs/namei.c
index e05d6ee..51841ec 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -2183,15 +2183,20 @@ int user_path_at(int dfd, const char __user *name, unsigned flags,
  *     path-walking is complete.
  */
 static struct getname_info *
-user_path_parent(int dfd, const char __user *path, struct nameidata *nd)
+user_path_parent(int dfd, const char __user *path, struct nameidata *nd,
+		 unsigned int reval)
 {
 	struct getname_info *s = getname(path);
 	int error;
+	unsigned int flags = LOOKUP_PARENT;
+
+	if (reval)
+		flags |= LOOKUP_REVAL;
 
 	if (IS_ERR(s))
 		return s;
 
-	error = ginfo_lookup(dfd, s, LOOKUP_PARENT, nd);
+	error = ginfo_lookup(dfd, s, flags, nd);
 	if (error) {
 		putname(s);
 		return ERR_PTR(error);
@@ -3339,7 +3344,7 @@ static long do_rmdir(int dfd, const char __user *pathname)
 	struct dentry *dentry;
 	struct nameidata nd;
 
-	name = user_path_parent(dfd, pathname, &nd);
+	name = user_path_parent(dfd, pathname, &nd, 0);
 	if (IS_ERR(name))
 		return PTR_ERR(name);
 
@@ -3435,7 +3440,7 @@ static long do_unlinkat(int dfd, const char __user *pathname)
 	struct nameidata nd;
 	struct inode *inode = NULL;
 
-	name = user_path_parent(dfd, pathname, &nd);
+	name = user_path_parent(dfd, pathname, &nd, 0);
 	if (IS_ERR(name))
 		return PTR_ERR(name);
 
@@ -3830,13 +3835,13 @@ SYSCALL_DEFINE4(renameat, int, olddfd, const char __user *, oldname,
 	struct getname_info *to;
 	int error;
 
-	from = user_path_parent(olddfd, oldname, &oldnd);
+	from = user_path_parent(olddfd, oldname, &oldnd, 0);
 	if (IS_ERR(from)) {
 		error = PTR_ERR(from);
 		goto exit;
 	}
 
-	to = user_path_parent(newdfd, newname, &newnd);
+	to = user_path_parent(newdfd, newname, &newnd, 0);
 	if (IS_ERR(to)) {
 		error = PTR_ERR(to);
 		goto exit1;
-- 
1.7.11.4

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2012-09-07 14:18 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-07 14:18 [PATCH v6 00/20] vfs: add the ability to retry on ESTALE to several syscalls Jeff Layton
2012-09-07 14:18 ` [PATCH v6 01/20] vfs: add a retry_estale helper function to handle retries on ESTALE Jeff Layton
2012-09-07 14:18 ` [PATCH v6 02/20] vfs: make fstatat retry on ESTALE errors from getattr call Jeff Layton
2012-09-07 14:18 ` [PATCH v6 03/20] vfs: fix readlinkat to retry on ESTALE Jeff Layton
2012-09-07 14:18 ` [PATCH v6 04/20] vfs: add new "reval" argument to kern_path_create and user_path_create Jeff Layton
2012-09-07 14:18 ` [PATCH v6 05/20] vfs: fix mknodat to retry on ESTALE errors Jeff Layton
2012-09-07 14:18 ` [PATCH v6 06/20] vfs: fix mkdir " Jeff Layton
2012-09-07 14:18 ` [PATCH v6 07/20] vfs: fix symlinkat " Jeff Layton
2012-09-07 14:18 ` [PATCH v6 08/20] vfs: fix linkat " Jeff Layton
2012-09-07 14:18 ` [PATCH v6 10/20] vfs: make rmdir " Jeff Layton
2012-09-07 14:18 ` [PATCH v6 11/20] vfs: make do_unlinkat " Jeff Layton
2012-09-07 14:18 ` [PATCH v6 12/20] vfs: fix renameat to " Jeff Layton
     [not found] ` <1347027507-20956-1-git-send-email-jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-09-07 14:18   ` Jeff Layton [this message]
2012-09-07 14:18   ` [PATCH v6 13/20] vfs: have do_sys_truncate retry once on an ESTALE error Jeff Layton
2012-09-07 14:18   ` [PATCH v6 17/20] vfs: make fchmodat retry once on ESTALE errors Jeff Layton
2012-09-07 14:18   ` [PATCH v6 18/20] vfs: make fchownat " Jeff Layton
2012-09-07 14:18 ` [PATCH v6 14/20] vfs: have faccessat retry once on an ESTALE error Jeff Layton
2012-09-07 14:18 ` [PATCH v6 15/20] vfs: have chdir retry lookup and call once on " Jeff Layton
2012-09-07 14:18 ` [PATCH v6 16/20] vfs: make chroot retry " Jeff Layton
2012-09-07 14:18 ` [PATCH v6 19/20] vfs: convert do_filp_open to use retry_estale helper Jeff Layton
2012-09-07 14:18 ` [PATCH v6 20/20] vfs: convert do_file_open_root " Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1347027507-20956-10-git-send-email-jlayton@redhat.com \
    --to=jlayton-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    --cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=michael.brantley-Iq/kdjr4a97QT0dZR+AlfA@public.gmane.org \
    --cc=miklos-sUDqSbJrdHQHWmgEVkV9KA@public.gmane.org \
    --cc=pstaubach-83r9SdEf25FBDgjK7y7TUQ@public.gmane.org \
    --cc=viro-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).