Re: [PATCH v2 3/4] hfsplus: rework functionality of getting, setting and deleting of extended attributes

[Vyacheslav Dubeyko <slava@dubeyko.com>]

Hi,

On Tue, 2012-09-25 at 05:45 -0400, Christoph Hellwig wrote:
> On Sun, Sep 23, 2012 at 06:49:37PM +0400, Vyacheslav Dubeyko wrote:
> > Hi,
> > 
> > This patch reworks functionality of getting, setting and deleting of extended attributes.
> 
> All new or modified xattr implementations should use the generic
> dispatching code and just set sb->s_xattr.
> 

As I can understand, you are talking about using xattr_handler's for
dispatching of processing of extended attributes with such complex names
as "system.posix_acl_access" and so on. Am I correct?

The HFS+ has such peculiarities that you can name extended attribute as
you want. And name of extended attribute can keep in Attributes Tree
without any prefixes (for example, as "test"). Moreover, it is not used
such prefixes as "user." or "system." under Mac OS X.

However, it exists under Mac OS X special prefix "com.apple." (for
example, "com.apple.FinderInfo"). So, you suggest to add definition of
additional prefixes "com." and "apple." in include/linux/xattr.h and to
add xattr_handler's for these two prefixes. Am I correct?

Of course, it has to implement xattr_handlers for
"system.posix_acl_access" and "system.posix_acl_default" in the case of
ACLs support implementation. But this patch set doesn't implement ACLs
support for HFS+.

With the best regards,
Vyacheslav Dubeyko.