From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vyacheslav Dubeyko Subject: Re: [PATCH v2 3/4] hfsplus: rework functionality of getting, setting and deleting of extended attributes Date: Tue, 25 Sep 2012 14:57:04 +0400 Message-ID: <1348570624.2033.59.camel@slavad-ubuntu-11> References: <4C976E84-D297-4A79-B6B3-F633F3204670@dubeyko.com> <20120925094508.GB22110@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, Andrew Morton , Al Viro , Hin-Tak Leung To: Christoph Hellwig Return-path: Received: from oproxy12-pub.bluehost.com ([50.87.16.10]:46295 "HELO oproxy12-pub.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754691Ab2IYK5H (ORCPT ); Tue, 25 Sep 2012 06:57:07 -0400 In-Reply-To: <20120925094508.GB22110@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hi, On Tue, 2012-09-25 at 05:45 -0400, Christoph Hellwig wrote: > On Sun, Sep 23, 2012 at 06:49:37PM +0400, Vyacheslav Dubeyko wrote: > > Hi, > > > > This patch reworks functionality of getting, setting and deleting of extended attributes. > > All new or modified xattr implementations should use the generic > dispatching code and just set sb->s_xattr. > As I can understand, you are talking about using xattr_handler's for dispatching of processing of extended attributes with such complex names as "system.posix_acl_access" and so on. Am I correct? The HFS+ has such peculiarities that you can name extended attribute as you want. And name of extended attribute can keep in Attributes Tree without any prefixes (for example, as "test"). Moreover, it is not used such prefixes as "user." or "system." under Mac OS X. However, it exists under Mac OS X special prefix "com.apple." (for example, "com.apple.FinderInfo"). So, you suggest to add definition of additional prefixes "com." and "apple." in include/linux/xattr.h and to add xattr_handler's for these two prefixes. Am I correct? Of course, it has to implement xattr_handlers for "system.posix_acl_access" and "system.posix_acl_default" in the case of ACLs support implementation. But this patch set doesn't implement ACLs support for HFS+. With the best regards, Vyacheslav Dubeyko.