From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yan Hong Subject: [PATCH 1/3] fs/block_dev.c: need not to check inode->i_bdev in bd_forget() Date: Wed, 26 Sep 2012 19:38:28 +0800 Message-ID: <1348659510-9059-1-git-send-email-clouds.yan@gmail.com> Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: akpm@linux-foundation.org Return-path: Received: from mail-da0-f46.google.com ([209.85.210.46]:42913 "EHLO mail-da0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753026Ab2IZLip (ORCPT ); Wed, 26 Sep 2012 07:38:45 -0400 Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Its only caller evict() has promised a non-NULL inode->i_bdev. Signed-off-by: Yan Hong --- fs/block_dev.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/fs/block_dev.c b/fs/block_dev.c index 38e721b..9bdbd9b 100644 --- a/fs/block_dev.c +++ b/fs/block_dev.c @@ -669,11 +669,9 @@ void bd_forget(struct inode *inode) struct block_device *bdev = NULL; spin_lock(&bdev_lock); - if (inode->i_bdev) { - if (!sb_is_blkdev_sb(inode->i_sb)) - bdev = inode->i_bdev; - __bd_forget(inode); - } + if (!sb_is_blkdev_sb(inode->i_sb)) + bdev = inode->i_bdev; + __bd_forget(inode); spin_unlock(&bdev_lock); if (bdev) -- 1.7.9.5