From: Yan Hong <clouds.yan@gmail.com>
To: akpm@linux-foundation.org
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Wu Fengguang <fengguang.wu@intel.com>
Subject: [PATCH 3/3] fs/fs-writeback.c: remove unneccesary parameter of __writeback_single_inode()
Date: Wed, 26 Sep 2012 19:38:30 +0800 [thread overview]
Message-ID: <1348659510-9059-3-git-send-email-clouds.yan@gmail.com> (raw)
In-Reply-To: <1348659510-9059-1-git-send-email-clouds.yan@gmail.com>
The parameter 'wb' is never used in this function.
Cc: Wu Fengguang <fengguang.wu@intel.com>
Signed-off-by: Yan Hong <clouds.yan@gmail.com>
---
fs/fs-writeback.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
index be3efc4..da746e8 100644
--- a/fs/fs-writeback.c
+++ b/fs/fs-writeback.c
@@ -438,8 +438,7 @@ static void requeue_inode(struct inode *inode, struct bdi_writeback *wb,
* setting I_SYNC flag and calling inode_sync_complete() to clear it.
*/
static int
-__writeback_single_inode(struct inode *inode, struct bdi_writeback *wb,
- struct writeback_control *wbc)
+__writeback_single_inode(struct inode *inode, struct writeback_control *wbc)
{
struct address_space *mapping = inode->i_mapping;
long nr_to_write = wbc->nr_to_write;
@@ -526,7 +525,7 @@ writeback_single_inode(struct inode *inode, struct bdi_writeback *wb,
inode->i_state |= I_SYNC;
spin_unlock(&inode->i_lock);
- ret = __writeback_single_inode(inode, wb, wbc);
+ ret = __writeback_single_inode(inode, wbc);
spin_lock(&wb->list_lock);
spin_lock(&inode->i_lock);
@@ -673,7 +672,7 @@ static long writeback_sb_inodes(struct super_block *sb,
* We use I_SYNC to pin the inode in memory. While it is set
* evict_inode() will wait so the inode cannot be freed.
*/
- __writeback_single_inode(inode, wb, &wbc);
+ __writeback_single_inode(inode, &wbc);
work->nr_pages -= write_chunk - wbc.nr_to_write;
wrote += write_chunk - wbc.nr_to_write;
--
1.7.9.5
next prev parent reply other threads:[~2012-09-26 11:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-26 11:38 [PATCH 1/3] fs/block_dev.c: need not to check inode->i_bdev in bd_forget() Yan Hong
2012-09-26 11:38 ` [PATCH 2/3] fs/debugsfs: get rid of unnecessary inode->i_private initialization Yan Hong
2012-09-26 11:38 ` Yan Hong [this message]
2012-09-26 12:51 ` [PATCH 3/3] fs/fs-writeback.c: remove unneccesary parameter of __writeback_single_inode() Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348659510-9059-3-git-send-email-clouds.yan@gmail.com \
--to=clouds.yan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).