Re: [PATCH v2 4/4] hfsplus: add support of manipulation by attributes file

[Vyacheslav Dubeyko <slava@dubeyko.com>]

Hi Hin-Tak,

On Mon, 2012-10-01 at 12:24 +0100, Hin-Tak Leung wrote:
> --- On Sun, 23/9/12, Vyacheslav Dubeyko <slava@dubeyko.com> wrote:
> 
> > Hi,
> > 
> > This patch adds support of manipulation by attributes file.
> > 
> > With the best regards,
> > Vyacheslav Dubeyko.
> > ---
> > From: Vyacheslav Dubeyko <slava@dubeyko.com>
> > Subject: [PATCH v2 4/4] hfsplus: add support of manipulation
> > by attributes file
> > 
> > This patch adds support of manipulation by attributes file.
> > 
> > Reported-by: Hin-Tak Leung <htl10@users.sourceforge.net>
> > Signed-off-by: Vyacheslav Dubeyko <slava@dubeyko.com>
> 
> Tested-by: Hin-Tak Leung <htl10@users.sourceforge.net>
> 

Thank you.

> Tried these 4 patches -together with the 5th which acted on code reviews and feedback. Works okay and fixed the two minor problems I had work v 1 (dubious warnings and interactions with selinux's use of extended atttributes).
> 
> There is a small problem though - this set of patches changes the file modes of some of the files, as seen below - just scroll further down... The other patches also touch the file modes where files are modified.
> 
> Hin-Tak
> 
> > ---
> >  fs/hfsplus/bfind.c     
> > |   79
> > ++++++++++++++++++++++++++++++++++++++++-------
> >  fs/hfsplus/bnode.c      |    6
> > ++--
> >  fs/hfsplus/brec.c   
> >    |   23 ++++++++------
> >  fs/hfsplus/btree.c      |    8
> > +++++
> >  fs/hfsplus/catalog.c    |   36
> > ++++++++++++---------
> >  fs/hfsplus/dir.c        |   
> > 6 +++-
> >  fs/hfsplus/extents.c    |    4 +--
> >  fs/hfsplus/hfsplus_fs.h |   41
> > +++++++++++++++++++++---
> >  fs/hfsplus/inode.c     
> > |   13 ++++++++
> >  fs/hfsplus/super.c     
> > |   36 +++++++++++++++++++--
> >  fs/hfsplus/unicode.c    |    7 +++--
> >  11 files changed, 210 insertions(+), 49 deletions(-)
> >  mode change 100644 => 100755 fs/hfsplus/bfind.c
> >  mode change 100644 => 100755 fs/hfsplus/bnode.c
> >  mode change 100644 => 100755 fs/hfsplus/brec.c
> >  mode change 100644 => 100755 fs/hfsplus/btree.c
> >  mode change 100644 => 100755 fs/hfsplus/catalog.c
> >  mode change 100644 => 100755 fs/hfsplus/dir.c
> >  mode change 100644 => 100755 fs/hfsplus/extents.c
> >  mode change 100644 => 100755 fs/hfsplus/hfsplus_fs.h
> >  mode change 100644 => 100755 fs/hfsplus/inode.c
> >  mode change 100644 => 100755 fs/hfsplus/super.c
> >  mode change 100644 => 100755 fs/hfsplus/unicode.c
> 
> Here - the file modes should not be touched...
> 

You are right. This is my mistake that was made during path set preparation.

As I can understand, these file mode changes were not adopted during adding to the -mm tree.

With the best regards,
Vyacheslav Dubeyko.