* [PATCH] fs: handle failed audit_log_start properly
@ 2012-10-04 23:57 Sasha Levin
2012-10-05 0:44 ` Al Viro
0 siblings, 1 reply; 2+ messages in thread
From: Sasha Levin @ 2012-10-04 23:57 UTC (permalink / raw)
To: viro, keescook
Cc: levinsasha928, davej, linux-fsdevel, linux-kernel, Sasha Levin
audit_log_start() may return NULL, this is unchecked by the caller in
audit_log_link_denied() and could cause a NULL ptr deref.
Introduced by commit a51d9eaa ("fs: add link restriction audit reporting").
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
---
kernel/audit.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/kernel/audit.c b/kernel/audit.c
index 4d0ceed..40414e9 100644
--- a/kernel/audit.c
+++ b/kernel/audit.c
@@ -1440,6 +1440,8 @@ void audit_log_link_denied(const char *operation, struct path *link)
ab = audit_log_start(current->audit_context, GFP_KERNEL,
AUDIT_ANOM_LINK);
+ if (!ab)
+ return;
audit_log_format(ab, "op=%s action=denied", operation);
audit_log_format(ab, " pid=%d comm=", current->pid);
audit_log_untrustedstring(ab, current->comm);
--
1.7.12
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fs: handle failed audit_log_start properly
2012-10-04 23:57 [PATCH] fs: handle failed audit_log_start properly Sasha Levin
@ 2012-10-05 0:44 ` Al Viro
0 siblings, 0 replies; 2+ messages in thread
From: Al Viro @ 2012-10-05 0:44 UTC (permalink / raw)
To: Sasha Levin; +Cc: keescook, levinsasha928, davej, linux-fsdevel, linux-kernel
On Thu, Oct 04, 2012 at 07:57:31PM -0400, Sasha Levin wrote:
> audit_log_start() may return NULL, this is unchecked by the caller in
> audit_log_link_denied() and could cause a NULL ptr deref.
>
> Introduced by commit a51d9eaa ("fs: add link restriction audit reporting").
Again, -stable fodder. Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-05 0:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-04 23:57 [PATCH] fs: handle failed audit_log_start properly Sasha Levin
2012-10-05 0:44 ` Al Viro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).