linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dave Kleikamp <dave.kleikamp@oracle.com>
To: linux-fsdevel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Zach Brown <zab@zabbo.net>,
	"Maxim V. Patlasov" <mpatlasov@parallels.com>,
	Asias He <asias@redhat.com>,
	Dave Kleikamp <dave.kleikamp@oracle.com>
Subject: [PATCH 22/22] block_dev: add support for read_iter, write_iter
Date: Mon, 22 Oct 2012 10:15:22 -0500	[thread overview]
Message-ID: <1350918922-6096-23-git-send-email-dave.kleikamp@oracle.com> (raw)
In-Reply-To: <1350918922-6096-1-git-send-email-dave.kleikamp@oracle.com>

From: Asias He <asias@redhat.com>

Use generic_file_read_iter for read_iter. Add blkdev_write_iter which is
based on blkdev_aio_write for write_iter.

Signed-off-by: Asias He <asias@redhat.com>
Signed-off-by: Dave Kleikamp <dave.kleikamp@oracle.com>
---
 fs/block_dev.c | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/fs/block_dev.c b/fs/block_dev.c
index ba3ed89..1a3aef9 100644
--- a/fs/block_dev.c
+++ b/fs/block_dev.c
@@ -1593,6 +1593,21 @@ static long block_ioctl(struct file *file, unsigned cmd, unsigned long arg)
 	return blkdev_ioctl(bdev, mode, cmd, arg);
 }
 
+static ssize_t blkdev_read_iter(struct kiocb *iocb, struct iov_iter *iter,
+				loff_t pos)
+{
+	ssize_t ret;
+	struct block_device *bdev = I_BDEV(iocb->ki_filp->f_mapping->host);
+
+	percpu_down_read(&bdev->bd_block_size_semaphore);
+
+	ret = generic_file_read_iter(iocb, iter, pos);
+
+	percpu_up_read(&bdev->bd_block_size_semaphore);
+
+	return ret;
+}
+
 ssize_t blkdev_aio_read(struct kiocb *iocb, const struct iovec *iov,
 			unsigned long nr_segs, loff_t pos)
 {
@@ -1609,6 +1624,25 @@ ssize_t blkdev_aio_read(struct kiocb *iocb, const struct iovec *iov,
 }
 EXPORT_SYMBOL_GPL(blkdev_aio_read);
 
+ssize_t blkdev_write_iter(struct kiocb *iocb, struct iov_iter *iter, loff_t pos)
+{
+	struct file *file = iocb->ki_filp;
+	ssize_t ret;
+
+	BUG_ON(iocb->ki_pos != pos);
+
+	ret = __generic_file_write_iter(iocb, iter, &pos);
+	if (ret > 0 || ret == -EIOCBQUEUED) {
+		ssize_t err;
+
+		err = generic_write_sync(file, pos, ret);
+		if (err < 0 && ret > 0)
+			ret = err;
+	}
+	return ret;
+}
+EXPORT_SYMBOL_GPL(blkdev_write_iter);
+
 /*
  * Write data to the block device.  Only intended for the block device itself
  * and the raw driver which basically is a fake block device.
@@ -1693,6 +1727,8 @@ const struct file_operations def_blk_fops = {
 	.write		= do_sync_write,
   	.aio_read	= blkdev_aio_read,
 	.aio_write	= blkdev_aio_write,
+	.read_iter	= blkdev_read_iter,
+	.write_iter	= blkdev_write_iter,
 	.mmap		= blkdev_mmap,
 	.fsync		= blkdev_fsync,
 	.unlocked_ioctl	= block_ioctl,
-- 
1.7.12.3

  parent reply	other threads:[~2012-10-22 15:15 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-22 15:15 [PATCH v3 00/22] loop: Issue O_DIRECT aio using bio_vec Dave Kleikamp
2012-10-22 15:15 ` [PATCH 01/22] iov_iter: move into its own file Dave Kleikamp
2012-10-22 15:15 ` [PATCH 02/22] iov_iter: iov_iter_copy_from_user() should use non-atomic copy Dave Kleikamp
2012-10-22 15:15 ` [PATCH 03/22] iov_iter: add copy_to_user support Dave Kleikamp
     [not found] ` <1350918922-6096-1-git-send-email-dave.kleikamp-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2012-10-22 15:15   ` [PATCH 04/22] fuse: convert fuse to use iov_iter_copy_[to|from]_user Dave Kleikamp
2012-10-22 15:15 ` [PATCH 05/22] iov_iter: hide iovec details behind ops function pointers Dave Kleikamp
2012-10-22 15:15 ` [PATCH 06/22] iov_iter: add bvec support Dave Kleikamp
2012-10-22 15:15 ` [PATCH 07/22] iov_iter: add a shorten call Dave Kleikamp
2012-10-22 15:15 ` [PATCH 08/22] iov_iter: let callers extract iovecs and bio_vecs Dave Kleikamp
2012-10-22 15:15 ` [PATCH 09/22] dio: create a dio_aligned() helper function Dave Kleikamp
2012-10-22 15:15 ` [PATCH 10/22] dio: Convert direct_IO to use iov_iter Dave Kleikamp
2012-10-22 15:15 ` [PATCH 11/22] dio: add bio_vec support to __blockdev_direct_IO() Dave Kleikamp
2012-10-22 15:15 ` [PATCH 12/22] fs: pull iov_iter use higher up the stack Dave Kleikamp
2012-10-22 15:15 ` [PATCH 13/22] aio: add aio_kernel_() interface Dave Kleikamp
2012-10-22 15:15 ` [PATCH 14/22] aio: add aio support for iov_iter arguments Dave Kleikamp
2012-10-22 15:15 ` [PATCH 15/22] bio: add bvec_length(), like iov_length() Dave Kleikamp
2012-10-22 15:15 ` [PATCH 16/22] loop: use aio to perform io on the underlying file Dave Kleikamp
2012-10-22 15:15 ` [PATCH 17/22] fs: add read_iter and write_iter to several file systems Dave Kleikamp
2012-10-22 15:15 ` [PATCH 18/22] ocfs2: add support for read_iter, write_iter, and direct_IO_bvec Dave Kleikamp
2012-10-22 15:15 ` [PATCH 19/22] ext4: add support for read_iter and write_iter Dave Kleikamp
2012-10-22 15:15 ` [PATCH 20/22] nfs: add support for read_iter, write_iter Dave Kleikamp
2012-10-22 15:21   ` Myklebust, Trond
2012-10-22 15:35     ` Dave Kleikamp
2012-10-22 15:15 ` [PATCH 21/22] btrfs: add support for read_iter and write_iter Dave Kleikamp
2012-10-22 15:15 ` Dave Kleikamp [this message]
2012-10-23  0:07 ` [PATCH v3 00/22] loop: Issue O_DIRECT aio using bio_vec Dave Chinner
2012-10-23  0:53   ` Dave Kleikamp
2012-10-23  1:59     ` Dave Chinner
2012-10-23 13:04 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1350918922-6096-23-git-send-email-dave.kleikamp@oracle.com \
    --to=dave.kleikamp@oracle.com \
    --cc=asias@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpatlasov@parallels.com \
    --cc=zab@zabbo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).