From: Sachin Prabhu <sprabhu@redhat.com>
To: Pavel Shilovsky <piastry@etersoft.ru>
Cc: linux-cifs <linux-cifs@vger.kernel.org>,
Steve French <smfrench@gmail.com>,
Jeff Layton <jlayton@redhat.com>,
vit.zahradka@tiscali.cz, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] cifs: Do not lookup hashed negative dentry in cifs_atomic_open
Date: Tue, 30 Oct 2012 19:20:17 +0000 [thread overview]
Message-ID: <1351624817.3038.12.camel@localhost> (raw)
In-Reply-To: <CAKywueTnmyeGU+rW3kNdS0AV8Vu=0nd_=AHyB47jnRH8AAqqpA@mail.gmail.com>
On Tue, 2012-10-30 at 22:30 +0400, Pavel Shilovsky wrote:
> > if (!(oflags & O_CREAT)) {
> > + /* Check for hashed negative dentry. We have already
> revalidated
> > + * the dentry and it is fine. No need to perform
> another lookup.
> > + */
>
> Patch looks ok, but the comment above doesn't match the kernel
> CodingStyle for block comments. While cifs code has a many places
> where it doesn't follow the style, we should keep new code as clean as
> possible.
Sorry about that. I had passed it through checkpatch.pl and it came out
fine. I checked the codestyle document and it appears that this style is
preferred only for files in net/ and drivers/net/. I am sending a v2 of
the patch with the small cosmetic change to ensure that it follows the
Coding Style.
Sachin Prabhu
prev parent reply other threads:[~2012-10-30 19:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-30 16:43 [PATCH] cifs: Do not lookup hashed negative dentry in cifs_atomic_open Sachin Prabhu
[not found] ` <1351615413-9182-1-git-send-email-sprabhu-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-10-30 16:46 ` Jeff Layton
2012-10-30 18:30 ` Pavel Shilovsky
2012-10-30 19:20 ` Sachin Prabhu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351624817.3038.12.camel@localhost \
--to=sprabhu@redhat.com \
--cc=jlayton@redhat.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=piastry@etersoft.ru \
--cc=smfrench@gmail.com \
--cc=vit.zahradka@tiscali.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).