* [PATCH 3/3] fat: remove unneeded compare condition for __fat_write_inode
@ 2012-11-11 13:58 Namjae Jeon
2012-11-11 16:10 ` OGAWA Hirofumi
0 siblings, 1 reply; 2+ messages in thread
From: Namjae Jeon @ 2012-11-11 13:58 UTC (permalink / raw)
To: hirofumi, akpm; +Cc: linux-fsdevel, linux-kernel, Namjae Jeon, Amit Sahrawat
In calling of __fat_write_inode(inode, wbc->sync_mode == WB_SYNC_ALL),
expression "wbc->sync_mode == WB_SYNC_ALL" will always be equivalent to value
of wbc->sync_mode. So, remove this additional compare condition from function
arguments.
Signed-off-by: Namjae Jeon <linkinjeon@gmail.com>
Signed-off-by: Amit Sahrawat <amit.sahrawat83@gmail.com>
---
fs/fat/inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/fat/inode.c b/fs/fat/inode.c
index 7b186a5..aa0138b 100644
--- a/fs/fat/inode.c
+++ b/fs/fat/inode.c
@@ -678,7 +678,7 @@ static int fat_write_inode(struct inode *inode, struct writeback_control *wbc)
err = fat_clusters_flush(sb);
mutex_unlock(&MSDOS_SB(sb)->s_lock);
} else
- err = __fat_write_inode(inode, wbc->sync_mode == WB_SYNC_ALL);
+ err = __fat_write_inode(inode, wbc->sync_mode);
return err;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 3/3] fat: remove unneeded compare condition for __fat_write_inode
2012-11-11 13:58 [PATCH 3/3] fat: remove unneeded compare condition for __fat_write_inode Namjae Jeon
@ 2012-11-11 16:10 ` OGAWA Hirofumi
0 siblings, 0 replies; 2+ messages in thread
From: OGAWA Hirofumi @ 2012-11-11 16:10 UTC (permalink / raw)
To: Namjae Jeon; +Cc: akpm, linux-fsdevel, linux-kernel, Amit Sahrawat
Namjae Jeon <linkinjeon@gmail.com> writes:
> In calling of __fat_write_inode(inode, wbc->sync_mode == WB_SYNC_ALL),
> expression "wbc->sync_mode == WB_SYNC_ALL" will always be equivalent to value
> of wbc->sync_mode. So, remove this additional compare condition from function
> arguments.
Current style is better. I.e. easy to add new sync mode.
> Signed-off-by: Namjae Jeon <linkinjeon@gmail.com>
> Signed-off-by: Amit Sahrawat <amit.sahrawat83@gmail.com>
> ---
> fs/fat/inode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/fat/inode.c b/fs/fat/inode.c
> index 7b186a5..aa0138b 100644
> --- a/fs/fat/inode.c
> +++ b/fs/fat/inode.c
> @@ -678,7 +678,7 @@ static int fat_write_inode(struct inode *inode, struct writeback_control *wbc)
> err = fat_clusters_flush(sb);
> mutex_unlock(&MSDOS_SB(sb)->s_lock);
> } else
> - err = __fat_write_inode(inode, wbc->sync_mode == WB_SYNC_ALL);
> + err = __fat_write_inode(inode, wbc->sync_mode);
>
> return err;
> }
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-11-11 16:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-11 13:58 [PATCH 3/3] fat: remove unneeded compare condition for __fat_write_inode Namjae Jeon
2012-11-11 16:10 ` OGAWA Hirofumi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).