linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dave Kleikamp <dave.kleikamp-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: fuse-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	Dave Kleikamp
	<dave.kleikamp-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
	Zach Brown <zab-ugsP4Wv/S6ZeoWH0uzbU5w@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	"Maxim V. Patlasov"
	<mpatlasov-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
Subject: [PATCH v4 04/31] fuse: convert fuse to use iov_iter_copy_[to|from]_user
Date: Wed, 21 Nov 2012 16:40:44 -0600	[thread overview]
Message-ID: <1353537671-26284-5-git-send-email-dave.kleikamp@oracle.com> (raw)
In-Reply-To: <1353537671-26284-1-git-send-email-dave.kleikamp-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>

A future patch hides the internals of struct iov_iter, so fuse should
be using the supported interface.

Signed-off-by: Dave Kleikamp <dave.kleikamp-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Acked-by: Miklos Szeredi <mszeredi-AlSwsSmVLrQ@public.gmane.org>
Cc: fuse-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
---
 fs/fuse/file.c | 29 ++++++++---------------------
 1 file changed, 8 insertions(+), 21 deletions(-)

diff --git a/fs/fuse/file.c b/fs/fuse/file.c
index 78d2837..4e42e95 100644
--- a/fs/fuse/file.c
+++ b/fs/fuse/file.c
@@ -1631,30 +1631,17 @@ static int fuse_ioctl_copy_user(struct page **pages, struct iovec *iov,
 	while (iov_iter_count(&ii)) {
 		struct page *page = pages[page_idx++];
 		size_t todo = min_t(size_t, PAGE_SIZE, iov_iter_count(&ii));
-		void *kaddr;
+		size_t left;
 
-		kaddr = kmap(page);
-
-		while (todo) {
-			char __user *uaddr = ii.iov->iov_base + ii.iov_offset;
-			size_t iov_len = ii.iov->iov_len - ii.iov_offset;
-			size_t copy = min(todo, iov_len);
-			size_t left;
-
-			if (!to_user)
-				left = copy_from_user(kaddr, uaddr, copy);
-			else
-				left = copy_to_user(uaddr, kaddr, copy);
-
-			if (unlikely(left))
-				return -EFAULT;
+		if (!to_user)
+			left = iov_iter_copy_from_user(page, &ii, 0, todo);
+		else
+			left = iov_iter_copy_to_user(page, &ii, 0, todo);
 
-			iov_iter_advance(&ii, copy);
-			todo -= copy;
-			kaddr += copy;
-		}
+		if (unlikely(left))
+			return -EFAULT;
 
-		kunmap(page);
+		iov_iter_advance(&ii, todo);
 	}
 
 	return 0;
-- 
1.8.0


------------------------------------------------------------------------------
Monitor your physical, virtual and cloud infrastructure from a single
web console. Get in-depth insight into apps, servers, databases, vmware,
SAP, cloud infrastructure, etc. Download 30-day Free Trial.
Pricing starts from $795 for 25 servers or applications!
http://p.sf.net/sfu/zoho_dev2dev_nov

  parent reply	other threads:[~2012-11-21 22:40 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-21 22:40 [PATCH v4 00/31] loop: Issue O_DIRECT aio using bio_vec Dave Kleikamp
2012-11-21 22:40 ` [PATCH v4 01/31] iov_iter: move into its own file Dave Kleikamp
2012-11-23  8:14   ` Christoph Hellwig
2012-11-23 17:34     ` Dave Kleikamp
2012-11-21 22:40 ` [PATCH v4 02/31] iov_iter: iov_iter_copy_from_user() should use non-atomic copy Dave Kleikamp
2012-11-21 22:40 ` [PATCH v4 03/31] iov_iter: add copy_to_user support Dave Kleikamp
     [not found] ` <1353537671-26284-1-git-send-email-dave.kleikamp-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2012-11-21 22:40   ` Dave Kleikamp [this message]
2012-11-21 22:40 ` [PATCH v4 05/31] iov_iter: hide iovec details behind ops function pointers Dave Kleikamp
2012-11-21 22:40 ` [PATCH v4 06/31] iov_iter: add bvec support Dave Kleikamp
2012-11-21 22:40 ` [PATCH v4 07/31] iov_iter: add a shorten call Dave Kleikamp
2012-11-21 22:40 ` [PATCH v4 08/31] iov_iter: let callers extract iovecs and bio_vecs Dave Kleikamp
2012-11-21 22:40 ` [PATCH v4 09/31] dio: create a dio_aligned() helper function Dave Kleikamp
2012-11-23  8:19   ` Christoph Hellwig
2012-11-23 17:45     ` Dave Kleikamp
2012-12-03 22:06     ` Dave Kleikamp
     [not found]       ` <50BD6C3E.8020809@oracle.com>
2012-12-04  3:39         ` Andi Kleen
2012-12-04  3:55           ` Dave Kleikamp
2012-11-21 22:40 ` [PATCH v4 10/31] dio: Convert direct_IO to use iov_iter Dave Kleikamp
2012-11-21 22:40 ` [PATCH v4 11/31] dio: add bio_vec support to __blockdev_direct_IO() Dave Kleikamp
2012-11-21 22:40 ` [PATCH v4 12/31] fs: pull iov_iter use higher up the stack Dave Kleikamp
2012-11-21 22:40 ` [PATCH v4 13/31] aio: add aio_kernel_() interface Dave Kleikamp
2012-11-21 22:40 ` [PATCH v4 14/31] aio: add aio support for iov_iter arguments Dave Kleikamp
2012-11-21 22:40 ` [PATCH v4 15/31] bio: add bvec_length(), like iov_length() Dave Kleikamp
2012-11-21 22:40 ` [PATCH v4 16/31] loop: use aio to perform io on the underlying file Dave Kleikamp
2012-11-22 23:06   ` Dave Chinner
2012-12-03 16:59     ` Dave Kleikamp
2012-12-04  2:52       ` Dave Chinner
2012-12-04  2:58         ` Dave Kleikamp
2012-11-21 22:40 ` [PATCH v4 17/31] fs: create file_readable() and file_writable() functions Dave Kleikamp
2012-11-21 22:40 ` [PATCH v4 18/31] fs: use read_iter and write_iter rather than aio_read and aio_write Dave Kleikamp
2012-11-21 22:40 ` [PATCH v4 19/31] fs: add read_iter and write_iter to several file systems Dave Kleikamp
2012-11-21 22:41 ` [PATCH v4 20/31] ocfs2: add support for read_iter, write_iter, and direct_IO_bvec Dave Kleikamp
2012-11-21 22:41 ` [PATCH v4 21/31] ext4: add support for read_iter and write_iter Dave Kleikamp
2012-11-21 22:41 ` [PATCH v4 22/31] nfs: add support for read_iter, write_iter Dave Kleikamp
2012-11-21 22:41 ` [PATCH v4 23/31] nfs: simplify swap Dave Kleikamp
     [not found]   ` <1353537671-26284-24-git-send-email-dave.kleikamp-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2012-11-23  8:21     ` Christoph Hellwig
2012-11-23 17:50       ` Dave Kleikamp
2012-11-21 22:41 ` [PATCH v4 24/31] btrfs: add support for read_iter and write_iter Dave Kleikamp
2012-11-21 22:41 ` [PATCH v4 25/31] block_dev: add support for read_iter, write_iter Dave Kleikamp
2012-11-21 22:41 ` [PATCH v4 26/31] xfs: add support for read_iter and write_iter Dave Kleikamp
2012-11-21 22:41 ` [PATCH v4 27/31] gfs2: Convert aio_read/write ops to read/write_iter Dave Kleikamp
2012-11-22  9:51   ` Steven Whitehouse
2012-11-22 22:59     ` Dave Chinner
2012-11-23 17:59       ` Dave Kleikamp
2012-12-03 19:14         ` Dave Kleikamp
2012-11-21 22:41 ` [PATCH v4 28/31] udf: convert file ops from aio_read/write " Dave Kleikamp
2012-11-21 22:41 ` [PATCH v4 29/31] afs: add support for read_iter and write_iter Dave Kleikamp
2012-11-21 22:41 ` [PATCH v4 30/31] ecrpytfs: Convert aio_read/write ops to read/write_iter Dave Kleikamp
2012-11-21 22:41 ` [PATCH v4 31/31] ubifs: convert file ops from aio_read/write " Dave Kleikamp
2012-11-22 19:47 ` [PATCH v4 00/31] loop: Issue O_DIRECT aio using bio_vec Christoph Hellwig
2012-11-23 17:33   ` Dave Kleikamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1353537671-26284-5-git-send-email-dave.kleikamp@oracle.com \
    --to=dave.kleikamp-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
    --cc=fuse-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mpatlasov-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org \
    --cc=zab-ugsP4Wv/S6ZeoWH0uzbU5w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).