From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Howells <dhowells@warthog.cambridge.redhat.com>
Subject: Re: [PATCH] PAG support only
Date: Wed, 14 May 2003 09:17:43 +0100
Sender: openafs-devel-admin@openafs.org
Message-ID: <13536.1052900263@warthog.warthog>
References: <20030513213759.A9244@infradead.org>
Mime-Version: 1.0 (generated by SEMI 1.14.4 - "Hosorogi")
Content-Type: text/plain; charset=US-ASCII
Cc: David Howells <dhowells@redhat.com>, torvalds@transmeta.com,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	openafs-devel@openafs.org
Return-path: <openafs-devel-admin@openafs.org>
To: Christoph Hellwig <hch@infradead.org>
In-Reply-To: <20030513213759.A9244@infradead.org> 
Errors-To: openafs-devel-admin@openafs.org
List-Help: <mailto:openafs-devel-request@openafs.org?subject=help>
List-Post: <mailto:openafs-devel@openafs.org>
List-Subscribe: <https://lists.openafs.org/mailman/listinfo/openafs-devel>,
	<mailto:openafs-devel-request@openafs.org?subject=subscribe>
List-Unsubscribe: <https://lists.openafs.org/mailman/listinfo/openafs-devel>,
	<mailto:openafs-devel-request@openafs.org?subject=unsubscribe>
List-Archive: <https://lists.openafs.org/pipermail/openafs-devel/>
List-Id: linux-fsdevel.vger.kernel.org


Christoph Hellwig wrote:

> Please split this into 2 lines as per Documentation/CodingStyle.  Even better
> make vfs_token_put handle a NULL argument.

Done the latter.

> Random whitespace change

Gone.

> - and even a wrong one..

I disagree, but no matter.

> > +static kmem_cache_t *vfs_token_cache;
> > +static kmem_cache_t *vfs_pag_cache;
> 
> How many of those will be around for a typical AFS client?  I have the vague
> feeling the slabs are overkill..

And then there's the people who said I shouldn't use kmalloc but should create
a slab instead...

> > +	if (pag>0) {
> > +		/* join existing PAG */
> > +		if (tsk->vfspag->pag &&
> > +		    tsk->vfspag->pag==pag)
> > +			return pag;
> 
> Please try to get your code in conformance with Documentation/CodingStyle.

You are suggesting what changes exactly?

David