From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vyacheslav Dubeyko Subject: Re: [PATCH] hfsplus: rework processing of return value of bio_alloc() in hfsplus_submit_bio() Date: Wed, 28 Nov 2012 17:18:19 +0400 Message-ID: <1354108699.2017.7.camel@slavad-ubuntu> References: <1354094854.2122.44.camel@slavad-ubuntu> <20121128124851.GA31769@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, Andrew Morton , Al Viro , Hin-Tak Leung To: Christoph Hellwig Return-path: Received: from oproxy6-pub.bluehost.com ([67.222.54.6]:54213 "HELO oproxy6-pub.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754136Ab2K1NSX (ORCPT ); Wed, 28 Nov 2012 08:18:23 -0500 In-Reply-To: <20121128124851.GA31769@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, 2012-11-28 at 07:48 -0500, Christoph Hellwig wrote: > On Wed, Nov 28, 2012 at 01:27:34PM +0400, Vyacheslav Dubeyko wrote: > > Hi, > > > > This patch adds logic of checking return value of bio_alloc() in hfsplus_submit_bio(). In the case of NULL the hfsplus_submit_bio() returns -EIO. > > bio_alloc does a mempool allocation and thus will never return NULL. > I don't insist on the patch. But if the function has such description: * RETURNS: * Pointer to new bio on success, NULL on failure. I prefer to check on NULL anyway. :-) With the best regards, Vyacheslav Dubeyko. > -- > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html