From mboxrd@z Thu Jan  1 00:00:00 1970
From: Vyacheslav Dubeyko <slava@dubeyko.com>
Subject: Re: [PATCH] hfsplus: rework processing of return value of
 bio_alloc() in hfsplus_submit_bio()
Date: Wed, 28 Nov 2012 17:37:23 +0400
Message-ID: <1354109843.2017.8.camel@slavad-ubuntu>
References: <1354094854.2122.44.camel@slavad-ubuntu>
	 <20121128124851.GA31769@infradead.org>
	 <1354108699.2017.7.camel@slavad-ubuntu>
	 <20121128132233.GA30413@infradead.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: linux-fsdevel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Hin-Tak Leung <htl10@users.sourceforge.net>
To: Christoph Hellwig <hch@infradead.org>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from oproxy9.bluehost.com ([69.89.24.6]:35840 "HELO
	oproxy9.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with SMTP id S1754509Ab2K1Nh1 (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Wed, 28 Nov 2012 08:37:27 -0500
In-Reply-To: <20121128132233.GA30413@infradead.org>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Wed, 2012-11-28 at 08:22 -0500, Christoph Hellwig wrote:
> On Wed, Nov 28, 2012 at 05:18:19PM +0400, Vyacheslav Dubeyko wrote:
> > I don't insist on the patch. But if the function has such description:
> > 
> >  *   RETURNS:
> >  *   Pointer to new bio on success, NULL on failure.
> > 
> > I prefer to check on NULL anyway. :-)
> 
> 
> Check the sentence a couple lines above in the same comment:
> 
>  *   When @bs is not NULL, if %__GFP_WAIT is set then bio_alloc will always be
>  *   able to allocate a bio. This is due to the mempool guarantees.
> 

Ok. Agree. Thank you. :-)

With the best regards,
Vyacheslav Dubeyko.