Re: [PATCH] hfsplus: rework processing of hfs_btree_write() returned error

[Vyacheslav Dubeyko <slava@dubeyko.com>]

On Sat, 2012-12-01 at 12:28 +0000, Hin-Tak Leung wrote:

[snip]
>         if (err) {
> > +           
> > printk(KERN_ERR "hfs: unable to write b-tree\n");
> > +           
> > dprint(DBG_INODE, "hfsplus_system_write_inode: %lu\n",
> > +           
> >     inode->i_ino);
> > +           
> > return err;
> > +        }
> > +    }
> >      return 0;
> >  }
> >  
> 
> There is a small issue which crossed my mind when I first noticed with:
> "hfsplus: rework processing errors in hfsplus_free_extents()"
> 
> It is a printk() followed by dprint() with additional information, on error. Because dprint() needs a compile-time change (or at least, echo'ing into debugfs if switched to dynamic-debug). This means the additional information would not be seen the first time the error occurred. I am wondering whether the additional info should be included in the printk - in a short-hand form, maybe?
> 

I think that your remark is reasonable. I'll prepare the patch.

Thanks,
Vyacheslav Dubeyko.

> Hin-Tak
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html