From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vyacheslav Dubeyko Subject: Re: [PATCH] hfsplus: rework processing of hfs_btree_write() returned error Date: Mon, 03 Dec 2012 10:02:42 +0400 Message-ID: <1354514562.2547.2.camel@slavad-ubuntu> References: <1354364883.63654.YahooMailClassic@web172306.mail.ir2.yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, Andrew Morton , Christoph Hellwig , Al Viro To: htl10@users.sourceforge.net Return-path: Received: from oproxy11-pub.bluehost.com ([173.254.64.10]:47653 "HELO oproxy11-pub.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1750712Ab2LCGC5 (ORCPT ); Mon, 3 Dec 2012 01:02:57 -0500 In-Reply-To: <1354364883.63654.YahooMailClassic@web172306.mail.ir2.yahoo.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sat, 2012-12-01 at 12:28 +0000, Hin-Tak Leung wrote: [snip] > if (err) { > > + > > printk(KERN_ERR "hfs: unable to write b-tree\n"); > > + > > dprint(DBG_INODE, "hfsplus_system_write_inode: %lu\n", > > + > > inode->i_ino); > > + > > return err; > > + } > > + } > > return 0; > > } > > > > There is a small issue which crossed my mind when I first noticed with: > "hfsplus: rework processing errors in hfsplus_free_extents()" > > It is a printk() followed by dprint() with additional information, on error. Because dprint() needs a compile-time change (or at least, echo'ing into debugfs if switched to dynamic-debug). This means the additional information would not be seen the first time the error occurred. I am wondering whether the additional info should be included in the printk - in a short-hand form, maybe? > I think that your remark is reasonable. I'll prepare the patch. Thanks, Vyacheslav Dubeyko. > Hin-Tak > > -- > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html