From: yangsheng <sickamd@gmail.com>
To: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Cc: stable@vger.kernel.org, adilger@dilger.ca, yangsheng <sickamd@gmail.com>
Subject: [PATCH] Update atime from future.
Date: Tue, 4 Dec 2012 01:56:39 +0800 [thread overview]
Message-ID: <1354557399-6202-1-git-send-email-sickamd@gmail.com> (raw)
Relatime should update the inode atime if it is more than a day in the
future. The original problem seen was a tarball that had a bad atime,
but could also happen if someone fat-fingers a "touch". The future
atime will never be fixed. Before the relatime patch, the future atime
would be updated back to the current time on the next access.
Only update the atime if it is more than one day in the future. That
avoids thrashing the atime if the clocks on clients of a network fs are
only slightly out of sync, but still allows fixing bogus atimes.
Signed-off-by: yangsheng <sickamd@gmail.com>
Reviewed-by: adilger@dilger.ca
---
fs/inode.c | 10 +++++++++-
1 files changed, 9 insertions(+), 1 deletions(-)
diff --git a/fs/inode.c b/fs/inode.c
index 14084b7..5c4379a 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -1465,6 +1465,7 @@ sector_t bmap(struct inode *inode, sector_t block)
}
EXPORT_SYMBOL(bmap);
+#define RELATIME_MARGIN (24*60*60)
/*
* With relative atime, only update atime if the previous atime is
* earlier than either the ctime or mtime or if at least a day has
@@ -1488,10 +1489,17 @@ static int relatime_need_update(struct vfsmount *mnt, struct inode *inode,
return 1;
/*
+ * Is the previous atime value in future? If yes,
+ * update atime:
+ */
+ if ((long)(now.tv_sec - inode->i_atime.tv_sec) < -RELATIME_MARGIN)
+ return 1;
+
+ /*
* Is the previous atime value older than a day? If yes,
* update atime:
*/
- if ((long)(now.tv_sec - inode->i_atime.tv_sec) >= 24*60*60)
+ if ((long)(now.tv_sec - inode->i_atime.tv_sec) >= RELATIME_MARGIN)
return 1;
/*
* Good, we can skip the atime update:
--
1.7.11.7
next reply other threads:[~2012-12-03 17:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-03 17:56 yangsheng [this message]
2012-12-03 18:08 ` [PATCH] Update atime from future Greg KH
2012-12-04 19:41 ` Zach Brown
2012-12-04 20:24 ` Dave Chinner
2012-12-05 0:22 ` Andreas Dilger
2012-12-07 0:49 ` Dave Chinner
-- strict thread matches above, loose matches on Subject: below --
2011-01-04 9:08 yangsheng
2010-12-29 13:58 yangsheng
2011-01-03 10:17 ` Andrew Morton
2011-01-03 12:54 ` YangSheng
2011-01-04 14:56 ` Rogier Wolff
2011-01-03 10:27 ` Steven Whitehouse
2011-01-03 16:27 ` Andreas Dilger
2011-01-03 16:41 ` Steven Whitehouse
2011-01-03 16:44 ` YangSheng
2011-01-11 13:33 ` Pavel Machek
2011-01-13 14:18 ` Steven Whitehouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1354557399-6202-1-git-send-email-sickamd@gmail.com \
--to=sickamd@gmail.com \
--cc=adilger@dilger.ca \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).