From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: [PATCH] fs: Fix imbalance in freeze protection in mark_files_ro() Date: Wed, 5 Dec 2012 14:40:14 +0100 Message-ID: <1354714814-7492-1-git-send-email-jack@suse.cz> Cc: linux-fsdevel@vger.kernel.org, LKML , Jan Kara , stable@vger.kernel.org To: Al Viro Return-path: Sender: stable-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org File descriptors (even those for writing) do not hold freeze protection. Thus mark_files_ro() must call __mnt_drop_write() to only drop protection against remount read-only. Calling mnt_drop_write_file() as we do now results in: [ BUG: bad unlock balance detected! ] 3.7.0-rc6-00028-g88e75b6 #101 Not tainted ------------------------------------- kworker/1:2/79 is trying to release lock (sb_writers) at: [] mnt_drop_write+0x24/0x30 but there are no more locks to release! Reported-by: Zdenek Kabelac CC: stable@vger.kernel.org Signed-off-by: Jan Kara --- fs/file_table.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Umm, this got lost for some reason... diff --git a/fs/file_table.c b/fs/file_table.c index a72bf9d..de9e965 100644 --- a/fs/file_table.c +++ b/fs/file_table.c @@ -458,8 +458,8 @@ void mark_files_ro(struct super_block *sb) spin_unlock(&f->f_lock); if (file_check_writeable(f) != 0) continue; + __mnt_drop_write(f->f_path.mnt); file_release_write(f); - mnt_drop_write_file(f); } while_file_list_for_each_entry; lg_global_unlock(&files_lglock); } -- 1.7.1