From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jaegeuk Kim Subject: Re: [PATCH 5/5] f2fs: Fix for parent inode information during server cache eviction Date: Mon, 10 Dec 2012 13:37:24 +0900 Message-ID: <1355114244.7291.60.camel@kjgkr> References: <1354946143-7730-1-git-send-email-linkinjeon@gmail.com> <1355100235.7291.52.camel@kjgkr> Reply-To: jaegeuk.kim@samsung.com Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-f4gkt9cWdKSsULmYajNy" Cc: linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Namjae Jeon , Amit Sahrawat To: Namjae Jeon Return-path: Received: from mailout4.samsung.com ([203.254.224.34]:42411 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751503Ab2LJEhi (ORCPT ); Sun, 9 Dec 2012 23:37:38 -0500 Received: from epcpsbgm1.samsung.com (epcpsbgm1 [203.254.230.26]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MES00H82STHM6M0@mailout4.samsung.com> for linux-fsdevel@vger.kernel.org; Mon, 10 Dec 2012 13:37:29 +0900 (KST) Received: from [12.52.126.105] by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MES009TFSUHGO10@mmp1.samsung.com> for linux-fsdevel@vger.kernel.org; Mon, 10 Dec 2012 13:37:29 +0900 (KST) In-reply-to: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: --=-f4gkt9cWdKSsULmYajNy Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable 2012-12-10 (=EC=9B=94), 12:40 +0900, Namjae Jeon: > 2012/12/10, Jaegeuk Kim : > > 2012-12-08 (=ED=86=A0), 14:55 +0900, Namjae Jeon: > >> From: Namjae Jeon > >> > >> Test Case: > >> [NFS Client] > >> ls -lR . > >> > >> [NFS Server] > >> while [ 1 ] > >> do > >> echo 3 > /proc/sys/vm/drop_caches > >> done > >> > >> Error: "No such file or directory" > >> > >> When cache is dropped at the server, it results in lookup failure at t= he > >> NFS client. Even though the file exists. Looking at the code to rebuil= d > >> the inode in case of cache eviction. It tries to initiate a lookup > >> operation > >> for ".." to get the parent information using the on-disk inode number. > >> > > > > Could you describe why this patch resolves that bug? > > Before applying this, we need to figure out why that bug is occurred. > > IMO, from the viewpoint of functionality, ".." resolution should work > > too. > dotdot entry of f2fs is stored when creating only directory not > regular file. Am I correct ? Yep. > So when the parent of file was evicted, I thought we could not get > parent inode number of file thoughout dotdot entry. What do you mean the parent of file? Isn't it a directory? > And f2fs inode is having parent inode number unlike other fs. so I > think we can use this special thing by storing f2fs_inode_info. f2fs stores a dotdot dentry *likewise* other fs. The pino in f2fs_inode is specially added for POR intentionally. Still I cannot imagine the bug scenario. >=20 > Thanks. > > Thanks, > > > > -- > > Jaegeuk Kim > > Samsung > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" = in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html --=20 Jaegeuk Kim Samsung --=-f4gkt9cWdKSsULmYajNy Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAABAgAGBQJQxWcFAAoJEEAUqH6CSFDS68YQAIeM4/o7Ey8U7q+ztF4/0cAi aI1VG3P5CqvG3hlLZjCbsfkUPv020WY/Ccf9Ve6LDV6lauTrENdHz5hyJp73Hixu nr9uCbd0nEP/3J6Wbmc+EB/bHN3SRXsqntk/QleQvI0dIeBVjNxFnaNv3FWdkPUk NBuvgFztqLJs+kaRP++dPjdHaykeeQeytg3+xW9DJDnU4Mh7+R3Ez2cp+MEMtUyB HyQz7GSRH3kLuAcmcPyogG8XZoGevnFkgW3HRpz7084/sU0eR9jCoMFs5zTZAXLa 8ki+H0nxd2qIKdUMFDGF6PZiUJpahAqJMVmV89XV8wK9kw/u2oRrZ3DIt3p/3ujN Mb/H2YZevtnTWW7n/B2Bm0lxgzF+nen0QAp71lHq1TjL8/hX+FYylR5w+W9lAuOZ +jrdw1OszjuEoeNWRanyxPy/1jxNexmkbvIWlxU1q1mS52EXQPpyf+wiiJZkfCQ8 pcd0DzV+1UEUKJlsqCsmBliHIEoY1nSKkWjcryBQeESKhIgFiQlTU6el3eCh9/f1 lUbUGgSsTaHXtKK80J3j1VFgeRztAhne4p3hSkTwge8Tguc8f2o+L5DZkoTAqa3U 8J3BS5/AAWk5fA9rEo3i0CSfn0D7ACLj96TdU5NL6MtIEdHEUmbXzWMr5a//Y+Ar CzpB7WU2Q+iS5ygz1Uxl =WdmO -----END PGP SIGNATURE----- --=-f4gkt9cWdKSsULmYajNy--