From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jaegeuk Kim Subject: Re: [PATCH] [f2fs-tools] mkfs: Make HDIO_GETGEO ioctl optional Date: Wed, 12 Dec 2012 11:19:01 +0900 Message-ID: <1355278741.24219.12.camel@kjgkr> References: <1355278115-12537-1-git-send-email-elezegarcia@gmail.com> Reply-To: jaegeuk.kim@samsung.com Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-VbHn4OK70QtmnyI18b8N" Cc: linux-fsdevel@vger.kernel.org, Ezequiel Garcia To: Ezequiel Garcia Return-path: Received: from mailout2.samsung.com ([203.254.224.25]:64025 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753681Ab2LLCTJ (ORCPT ); Tue, 11 Dec 2012 21:19:09 -0500 Received: from epcpsbgm1.samsung.com (epcpsbgm1 [203.254.230.26]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MEW009UIBRP0TF0@mailout2.samsung.com> for linux-fsdevel@vger.kernel.org; Wed, 12 Dec 2012 11:19:07 +0900 (KST) Received: from [12.52.126.105] by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MEW00KVZBRVV350@mmp1.samsung.com> for linux-fsdevel@vger.kernel.org; Wed, 12 Dec 2012 11:19:07 +0900 (KST) In-reply-to: <1355278115-12537-1-git-send-email-elezegarcia@gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: --=-VbHn4OK70QtmnyI18b8N Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable 2012-12-11 (=ED=99=94), 23:08 -0300, Ezequiel Garcia: > From: Ezequiel Garcia >=20 > Some block devices don't implement HDIO_GETGEP ioctl; > loop device being a notable example. > Without this patch, it's not possible to make a f2fs > on a file mounted over a loop device. >=20 > Signed-off-by: Ezequiel Garcia > --- > mkfs/f2fs_format.c | 9 ++++----- > 1 files changed, 4 insertions(+), 5 deletions(-) >=20 > diff --git a/mkfs/f2fs_format.c b/mkfs/f2fs_format.c > index d3e1d0c..b542db5 100644 > --- a/mkfs/f2fs_format.c > +++ b/mkfs/f2fs_format.c > @@ -262,11 +262,10 @@ static int8_t f2fs_get_device_info() > return -1; > } > =20 > - if (ioctl(fd, HDIO_GETGEO, &geom) < 0) { > - printf("\n\tError: Cannot get the device geometry\n"); > - return -1; > - } > - f2fs_params.start_sector =3D geom.start; > + if (ioctl(fd, HDIO_GETGEO, &geom) < 0) > + f2fs_params.start_sector =3D 0; > + else > + f2fs_params.start_sector =3D geom.start; > } > else { > printf("\n\n\tError: Volume type is not supported!!!\n"); Merged, thanks. :) --=20 Jaegeuk Kim Samsung --=-VbHn4OK70QtmnyI18b8N Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAABAgAGBQJQx+mVAAoJEEAUqH6CSFDSuukP/3wSwm2bKvj5TknhZg1G5fWH LCaZ/dzM6kVBvSmCXA/uOWmq2CQvRO8XhBNiwtL27JDuLNOgbyr2xy80C5QgmfaY M0VU2jBYOPQZXl62aSVkUgq7+sZr4js7S7SL1t4ePU/bIfhjRXEMMau7vv07WUWj T6RADf0P0hwZjzOw5FH/XUWW4vrADHP+0HJPp7NjEhYfKH/+pY9dx60t/R0E40qi JhVyiziwv1wuH65LUd33fD3CuVwff66WUv/x0tcKj+jfsSrnSfmCgZBkSGF9otPr Z9A1+59zDO0Bzj+YuRhyl8XwAGIBCrf0yB3xQRc2DMgmKEIQXrYI7OCcHfjD6z9r y9tIPdqd0gDlVMHzwXlUuIraG01d9lHqQbV64qfWSp5zquHgyUo9Uy5r4kJIKYyh V/eo8WcdISsGALYdq4r/Nbh/eiS5tu1tpuJJbL88Yli9+tV5AilfhENnTWjp/22Q TRpal9vC/6KhHJkxZWemWG5SflskzTbmBBQUbCvQtitMKoDKy5HzpYJkaA9NbpCo tc6Ku8sgL/dwBOD+PWifaHM/zQ95x0Q/99AGsQVaBa0ukQKTZP/jOPTqYD93+OfQ c7m+Sg1AtBtMDD8PLB+x6m3qk9K3AOK/cN/rgCessTCF0qNj28JaaKjRbX3PswSj /QBbWN2tH2QmLVT9nc6t =mWhy -----END PGP SIGNATURE----- --=-VbHn4OK70QtmnyI18b8N--