Re: [PATCH v2] hfsplus: avoid crash on failed block map free

[Vyacheslav Dubeyko <slava@dubeyko.com>]

On Tue, 2012-12-18 at 22:29 -0800, Andrew Morton wrote:
> On Wed, 19 Dec 2012 10:26:37 +0400 Vyacheslav Dubeyko <slava@dubeyko.com> wrote:
> 
> > > > So, as you can see the discussion revives again. :-) And I need to
> > > > familiarize with implementation of xattrs in JFS before to answer again.
> > > > I had objection that we need to remember about using HFS+ volumes as
> > > > under Linux as under Mac OS X. Maybe, JFS implementation of xattrs to
> > > > change my vision.
> > > 
> > > I'm still unclear where we stand with these patches.  Which if any of
> > > these should I merge?
> > > 
> > 
> > As I can see these patches contain implementation of xattr support (v3)
> > and reworked error processing in some parts of hfsplus driver. The
> > version 3 of xattr support was implemented after remarks of Christoph
> > Hellwig about necessity to have "osx." prefix. So, after this e-mail we
> > had achieved understanding about proper implementation and it was done.
> > 
> > Maybe I misunderstand something but I thought that these patches were
> > merged in linux-next yet. Or do you talking about merging in mainline?
> > 
> > Currently, I am working on ACLs support in hfsplus driver. But, from my
> > point of view, these patches are important and without ACLs support.
> 
> Yes, they've all been in linux-next for a while.
> 
> To be more specific: is Christoph OK with a mainline merge?

I think that we need to ask his about it. :-) I haven't any private
e-mailing with him about it.

Maybe, it makes sense to merge in mainline reworked error processing
patches previously and, then, to merge the xattr support after ACLs
support implementation.

Christoph, could you share your opinion?

With the best regards,
Vyacheslav Dubeyko.

> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html