From: "Fernando Luis Vázquez Cao" <fernando_b1@lab.ntt.co.jp>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Josef Bacik <jbacik@fusionio.com>,
Eric Sandeen <sandeen@redhat.com>,
Dave Chinner <dchinner@redhat.com>,
Christoph Hellwig <hch@infradead.org>, Jan Kara <jack@suse.cz>,
Luiz Capitulino <lcapitulino@redhat.com>,
linux-fsdevel@vger.kernel.org
Subject: [PATCH v6 0/17] fsfreeze: miscellaneous fixes and cleanups
Date: Mon, 07 Jan 2013 20:18:12 +0900 [thread overview]
Message-ID: <1357557492.8183.1.camel@nexus.lab.ntt.co.jp> (raw)
This patch set addresses several long standing issues:
- Fix emergency thaw (patch 1 through 4) and make some cleanups while at it
(patches 5 and 6).
- Fix nested freezes for superblock-less block devices (patch 7).
- Integrate sb-level/bdev-level fsfreeze and sanitize the fsfreeze API to
avoid perpetual frost in the event of changes in the filesystem namespace
(patch 8 through 13).
- Add infrastructure needed to support dm-initiated freeze of filesystems
spanning several bdevs and actually use it to implement this feature in
btrfs (patch 14 through 16).
- Export freeze state to userspace through mountinfo (patch 17).
---
[1/17] vfs: add __iterate_supers() and helpers around it
[2/17] fsfreeze: add unlocked version of thaw_super
Preparatory patches to fix s_umount lockup of emergency thaw code.
[3/17] fsfreeze: fix emergency thaw infinite loop
Fix thaw_bdev so that it propagates the error code properly to the caller.
This bug caused emergency thaw to loop infinitely. This is a forward port of
a previous patch by Dave Chinner.
[4/17] fsfreeze: emergency thaw will deadlock on s_umount
Avoid emergency thaw deadlock on s_umount by using unlocked version of
thaw_super() and __iterate_supers() (introduced in patches 2 and 1
respectively).
[5/17] xfs: switch to using super methods for fsfreeze
[6/17] fsfreeze: move emergency thaw code to fs/super.c
Two cleanups (based on previous patches by David Chinner): convert xfs to using
superblock methods for fsfreeze and move emergency thaw code to where it
belongs.
[7/17] fsfreeze: fix nested freezing of sb-less bdevs
Get nested freezes working for sb-less bdevs.
[8/17] fsfreeze: allow bdev level thaws when the sb is unfrozen
[9/17] fsfreeze: freeze_super and thaw_bdev don't play well together
Restore the re-entrancy guards in sb-level API as the first step to achieve
proper sb-level/bdev-level fsfreeze integration.
[10/17] fsfreeze: automatically thaw on umount
The fsfreeze ioctls are a sb-level API which means that to thaw a frozen
filesystem it is necessary to have it in our filesystem hierarchy. To avoid
being stuck with a frozen filesystem and frozen processes by accident, we
automatically thaw filesystems on sys_umount().
[11/17] fsfreeze: add thaw_super_force
Both emergecy thaw and the umount-time automatic thaw need to make sure that
the thaw operation does not fail so with some code refactoring we can share
and clean up the code.
[12/17] fsfreeze: sb-level/bdev-level fsfreeze integration
[13/17] fsfreeze: unfreeze bdevs in addition to filesystems during emergency thaw
Fix the problem that a filesystem frozen through the bdev level API can be
thawed using the superblock level API and make sure that their respective
freeze counters are always consistent with each other.
[14/17] vfs: leverage bd_super in get_super and get_active_super
[15/17] btrfs: store pointer to superblock in bd_super
[16/17] fsfreeze: allow freeze counter lock nesting
Leverage bd_super in get_active_super to be able to get the superblock from the bdev when the filesystem spans several bdevs. Once this is in place, getting
thaw_bdev(), i.e. dm snapshot, and btrfs to play well together is just a matter
of using bd_super in btrfs.
[17/17] fsfreeze: export freeze_count through mountinfo
Export freeze_count through mountinfo so that we have a way to figure out the
current freeze state from userspace.
---
Changes since: v5:
- Fix patch 4 ("fsfreeze: emergency thaw will deadlock on s_umount").
- Add Jan Kara's Reviewed-by to patch 9 ("fsfreeze: freeze_super and
thaw_bdev don't play well together").
- Exclude conflictive check ioctls from the patch set (could be back in a
follow-up patch set) and add a patch to export freeze state to userspace
through mountinfo.
- Add fix for nested freezing of sb-less bdevs.
- Rewrite the patches to integrate sb-level/bdev-level fsfreeze and sanitize
the fsfreeze API (including automatical thawing of filesystems on umount).
- Add infrastructure needed to support dm-initiated freeze of filesystems
spanning several bdevs and actually use it to implement this feature in
btrfs.
Changes since v4:
- Make implementation of iterate_supers_read and iterate_supers_write
symmetric and update locking of emergency thaw code accordingly.
- Add Jan Kara's Reviewed-by to patch 2.
- Add explanation about the change from a block device based emergency thaw
to a superblock based one to patch 4.
- Modify patch 7 so that the new superblock based emergency does not leave
the block device level fsfreeze counter in an inconsistent state.
- Update and comment handling of fsfreeze during mount.
Changes since v3:
- Include right version of the emergency thaw fix (thanks go to Josef for the
heads up).
- Add iterate_supers_(read/write) helpers as suggested by Eric Sandeen.
- Fix typos.
- Add Eric Sandeen's Reviewed-by to patches 2 and 3.
Changes since v2:
- Rebase on top of Jan Kara's patch set which made it upstream.
- Do without the horrible "emergency" parameter as suggested by Jan Kara.
- New approach to fix emergency thaw deadlock on s_umount which does locking
properly.
Changes since v1:
- Do not break unfreezing of block devices without a mounted filesystem.
- Avoid conditional locking in thaw_bdev.
- Update filesystem locking documentation.
next reply other threads:[~2013-01-07 11:30 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-07 11:18 Fernando Luis Vázquez Cao [this message]
2013-01-07 11:21 ` [PATCH 1/17] vfs: add __iterate_supers() and helpers around it Fernando Luis Vázquez Cao
2013-01-07 11:22 ` [PATCH 2/17] fsfreeze: add unlocked version of thaw_super Fernando Luis Vázquez Cao
2013-01-07 11:23 ` [PATCH 3/17] fsfreeze: fix emergency thaw infinite loop Fernando Luis Vázquez Cao
2013-01-07 11:26 ` [PATCH 4/17] fsfreeze: emergency thaw will deadlock on s_umount Fernando Luis Vázquez Cao
2013-01-09 16:12 ` Jan Kara
2013-01-07 11:27 ` [PATCH 5/17] xfs: switch to using super methods for fsfreeze Fernando Luis Vázquez Cao
2013-01-07 11:29 ` [PATCH 6/17] fsfreeze: move emergency thaw code to fs/super.c Fernando Luis Vázquez Cao
2013-01-07 11:30 ` [PATCH 7/17] fsfreeze: fix nested freezing of sb-less bdevs Fernando Luis Vázquez Cao
2013-01-09 16:24 ` Jan Kara
2013-01-07 11:32 ` [PATCH 8/17] fsfreeze: allow bdev level thaws when the sb is unfrozen Fernando Luis Vázquez Cao
2013-01-09 16:26 ` Jan Kara
2013-01-07 11:34 ` [PATCH 9/17] fsfreeze: freeze_super and thaw_bdev don't play well together Fernando Luis Vázquez Cao
2013-01-07 11:35 ` [PATCH 10/17] fsfreeze: automatically thaw on umount Fernando Luis Vázquez Cao
2013-01-09 17:20 ` Jan Kara
2013-01-10 9:14 ` Fernando Luis Vazquez Cao
2013-01-07 11:36 ` [PATCH 11/17] fsfreeze: add thaw_super_force Fernando Luis Vázquez Cao
2013-01-07 11:38 ` [PATCH 12/17] fsfreeze: sb-level/bdev-level fsfreeze integration Fernando Luis Vázquez Cao
2013-01-09 16:37 ` Jan Kara
2013-01-10 9:57 ` Fernando Luis Vazquez Cao
2013-01-07 11:39 ` [PATCH 13/17] fsfreeze: unfreeze bdevs in addition to filesystems during emergency thaw Fernando Luis Vázquez Cao
2013-01-09 16:41 ` Jan Kara
2013-01-07 11:41 ` [PATCH 14/17] vfs: leverage bd_super in get_super and get_active_super Fernando Luis Vázquez Cao
2013-01-09 16:44 ` Jan Kara
2013-01-07 11:42 ` [PATCH 15/17] btrfs: store pointer to superblock in bd_super Fernando Luis Vázquez Cao
2013-01-07 11:43 ` [PATCH 16/17] fsfreeze: allow freeze counter lock nesting Fernando Luis Vázquez Cao
2013-01-07 11:44 ` [PATCH 17/17] fsfreeze: export freeze_count through mountinfo Fernando Luis Vázquez Cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357557492.8183.1.camel@nexus.lab.ntt.co.jp \
--to=fernando_b1@lab.ntt.co.jp \
--cc=dchinner@redhat.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=jbacik@fusionio.com \
--cc=lcapitulino@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).