From: Dave Kleikamp <dave.kleikamp@oracle.com>
To: linux-fsdevel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Zach Brown <zab@zabbo.net>,
"Maxim V. Patlasov" <mpatlasov@parallels.com>,
Asias He <asias@redhat.com>,
Dave Kleikamp <dave.kleikamp@oracle.com>
Subject: [PATCH V5 24/30] block_dev: add support for read_iter, write_iter
Date: Wed, 9 Jan 2013 13:58:39 -0600 [thread overview]
Message-ID: <1357761525-22718-25-git-send-email-dave.kleikamp@oracle.com> (raw)
In-Reply-To: <1357761525-22718-1-git-send-email-dave.kleikamp@oracle.com>
From: Asias He <asias@redhat.com>
Signed-off-by: Asias He <asias@redhat.com>
Signed-off-by: Dave Kleikamp <dave.kleikamp@oracle.com>
---
drivers/char/raw.c | 4 ++--
fs/block_dev.c | 19 +++++++++----------
include/linux/fs.h | 4 ++--
3 files changed, 13 insertions(+), 14 deletions(-)
diff --git a/drivers/char/raw.c b/drivers/char/raw.c
index 54a3a6d..443c2d8 100644
--- a/drivers/char/raw.c
+++ b/drivers/char/raw.c
@@ -285,9 +285,9 @@ static long raw_ctl_compat_ioctl(struct file *file, unsigned int cmd,
static const struct file_operations raw_fops = {
.read = do_sync_read,
- .aio_read = generic_file_aio_read,
+ .read_iter = generic_file_read_iter,
.write = do_sync_write,
- .aio_write = blkdev_aio_write,
+ .write_iter = blkdev_write_iter,
.fsync = blkdev_fsync,
.open = raw_open,
.release = raw_release,
diff --git a/fs/block_dev.c b/fs/block_dev.c
index df8aa76..039ae6a 100644
--- a/fs/block_dev.c
+++ b/fs/block_dev.c
@@ -1521,8 +1521,7 @@ static long block_ioctl(struct file *file, unsigned cmd, unsigned long arg)
* Does not take i_mutex for the write and thus is not for general purpose
* use.
*/
-ssize_t blkdev_aio_write(struct kiocb *iocb, const struct iovec *iov,
- unsigned long nr_segs, loff_t pos)
+ssize_t blkdev_write_iter(struct kiocb *iocb, struct iov_iter *iter, loff_t pos)
{
struct file *file = iocb->ki_filp;
struct blk_plug plug;
@@ -1531,7 +1530,7 @@ ssize_t blkdev_aio_write(struct kiocb *iocb, const struct iovec *iov,
BUG_ON(iocb->ki_pos != pos);
blk_start_plug(&plug);
- ret = __generic_file_aio_write(iocb, iov, nr_segs, &iocb->ki_pos);
+ ret = __generic_file_write_iter(iocb, iter, &iocb->ki_pos);
if (ret > 0 || ret == -EIOCBQUEUED) {
ssize_t err;
@@ -1542,10 +1541,10 @@ ssize_t blkdev_aio_write(struct kiocb *iocb, const struct iovec *iov,
blk_finish_plug(&plug);
return ret;
}
-EXPORT_SYMBOL_GPL(blkdev_aio_write);
+EXPORT_SYMBOL_GPL(blkdev_write_iter);
-static ssize_t blkdev_aio_read(struct kiocb *iocb, const struct iovec *iov,
- unsigned long nr_segs, loff_t pos)
+static ssize_t blkdev_read_iter(struct kiocb *iocb, struct iov_iter *iter,
+ loff_t pos)
{
struct file *file = iocb->ki_filp;
struct inode *bd_inode = file->f_mapping->host;
@@ -1556,8 +1555,8 @@ static ssize_t blkdev_aio_read(struct kiocb *iocb, const struct iovec *iov,
size -= pos;
if (size < INT_MAX)
- nr_segs = iov_shorten((struct iovec *)iov, nr_segs, size);
- return generic_file_aio_read(iocb, iov, nr_segs, pos);
+ iov_iter_shorten(iter, size);
+ return generic_file_read_iter(iocb, iter, pos);
}
/*
@@ -1590,8 +1589,8 @@ const struct file_operations def_blk_fops = {
.llseek = block_llseek,
.read = do_sync_read,
.write = do_sync_write,
- .aio_read = blkdev_aio_read,
- .aio_write = blkdev_aio_write,
+ .read_iter = blkdev_read_iter,
+ .write_iter = blkdev_write_iter,
.mmap = generic_file_mmap,
.fsync = blkdev_fsync,
.unlocked_ioctl = block_ioctl,
diff --git a/include/linux/fs.h b/include/linux/fs.h
index 679c7cc..8cc8b0d 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -2485,8 +2485,8 @@ extern int generic_segment_checks(const struct iovec *iov,
unsigned long *nr_segs, size_t *count, int access_flags);
/* fs/block_dev.c */
-extern ssize_t blkdev_aio_write(struct kiocb *iocb, const struct iovec *iov,
- unsigned long nr_segs, loff_t pos);
+extern ssize_t blkdev_write_iter(struct kiocb *iocb, struct iov_iter *iter,
+ loff_t pos);
extern int blkdev_fsync(struct file *filp, loff_t start, loff_t end,
int datasync);
extern void block_sync_page(struct page *page);
--
1.8.1
next prev parent reply other threads:[~2013-01-09 19:58 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-09 19:58 [PATCH V5 00/30] loop: Issue O_DIRECT aio using bio_vec Dave Kleikamp
2013-01-09 19:58 ` [PATCH V5 01/30] iov_iter: move into its own file Dave Kleikamp
2013-01-09 19:58 ` [PATCH V5 02/30] iov_iter: iov_iter_copy_from_user() should use non-atomic copy Dave Kleikamp
2013-01-09 19:58 ` [PATCH V5 03/30] iov_iter: add copy_to_user support Dave Kleikamp
2013-01-09 19:58 ` [PATCH V5 05/30] iov_iter: hide iovec details behind ops function pointers Dave Kleikamp
2013-01-09 19:58 ` [PATCH V5 06/30] iov_iter: add bvec support Dave Kleikamp
2013-01-09 19:58 ` [PATCH V5 07/30] iov_iter: add a shorten call Dave Kleikamp
2013-01-09 19:58 ` [PATCH V5 08/30] iov_iter: let callers extract iovecs and bio_vecs Dave Kleikamp
2013-01-09 19:58 ` [PATCH V5 09/30] dio: Convert direct_IO to use iov_iter Dave Kleikamp
2013-01-09 19:58 ` [PATCH V5 10/30] dio: add bio_vec support to __blockdev_direct_IO() Dave Kleikamp
2013-01-09 19:58 ` [PATCH V5 11/30] fs: pull iov_iter use higher up the stack Dave Kleikamp
2013-01-09 19:58 ` [PATCH V5 12/30] aio: add aio_kernel_() interface Dave Kleikamp
2013-01-09 19:58 ` [PATCH V5 13/30] aio: add aio support for iov_iter arguments Dave Kleikamp
2013-01-09 19:58 ` [PATCH V5 14/30] bio: add bvec_length(), like iov_length() Dave Kleikamp
2013-01-09 19:58 ` [PATCH V5 15/30] loop: use aio to perform io on the underlying file Dave Kleikamp
2013-01-09 19:58 ` [PATCH V5 16/30] fs: create file_readable() and file_writable() functions Dave Kleikamp
2013-01-09 19:58 ` [PATCH V5 17/30] fs: use read_iter and write_iter rather than aio_read and aio_write Dave Kleikamp
2013-01-18 21:26 ` Jeff Moyer
2013-01-18 22:03 ` Dave Kleikamp
2013-01-09 19:58 ` [PATCH V5 18/30] fs: add read_iter and write_iter to several file systems Dave Kleikamp
2013-01-10 12:40 ` Boaz Harrosh
2013-01-09 19:58 ` [PATCH V5 19/30] ocfs2: add support for read_iter, write_iter, and direct_IO_bvec Dave Kleikamp
2013-01-09 19:58 ` [PATCH V5 20/30] ext4: add support for read_iter and write_iter Dave Kleikamp
2013-01-09 19:58 ` [PATCH V5 21/30] nfs: add support for read_iter, write_iter Dave Kleikamp
[not found] ` <1357761525-22718-1-git-send-email-dave.kleikamp-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2013-01-09 19:58 ` [PATCH V5 04/30] fuse: convert fuse to use iov_iter_copy_[to|from]_user Dave Kleikamp
2013-01-09 19:58 ` [PATCH V5 22/30] nfs: simplify swap Dave Kleikamp
2013-01-09 20:01 ` Rik van Riel
2013-01-09 19:58 ` [PATCH V5 23/30] btrfs: add support for read_iter and write_iter Dave Kleikamp
2013-01-09 19:58 ` Dave Kleikamp [this message]
2013-01-09 19:58 ` [PATCH V5 25/30] xfs: " Dave Kleikamp
2013-01-09 19:58 ` [PATCH V5 26/30] gfs2: Convert aio_read/write ops to read/write_iter Dave Kleikamp
2013-01-10 10:10 ` Steven Whitehouse
2013-01-10 14:34 ` Dave Kleikamp
2013-01-11 16:24 ` Steven Whitehouse
2013-01-09 19:58 ` [PATCH V5 27/30] udf: convert file ops from aio_read/write " Dave Kleikamp
2013-01-09 19:58 ` [PATCH V5 28/30] afs: add support for read_iter and write_iter Dave Kleikamp
2013-01-09 19:58 ` [PATCH V5 29/30] ecrpytfs: Convert aio_read/write ops to read/write_iter Dave Kleikamp
2013-01-09 19:58 ` [PATCH V5 30/30] ubifs: convert file ops from aio_read/write " Dave Kleikamp
2013-01-10 15:46 ` [PATCH V5 00/30] loop: Issue O_DIRECT aio using bio_vec Sedat Dilek
2013-01-11 21:51 ` Dave Kleikamp
2013-01-12 10:52 ` Sedat Dilek
2013-01-12 12:54 ` Sedat Dilek
2013-01-16 16:32 ` James Bottomley
2013-01-16 18:25 ` Sedat Dilek
2013-01-17 23:49 ` James Bottomley
2013-01-18 17:16 ` Jeff Moyer
2013-01-18 17:56 ` Jeff Moyer
2013-01-18 17:58 ` Dave Kleikamp
2013-01-18 21:48 ` Jeff Moyer
2013-01-18 22:33 ` Dave Kleikamp
2013-01-22 16:14 ` Jeff Moyer
2013-01-20 22:26 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357761525-22718-25-git-send-email-dave.kleikamp@oracle.com \
--to=dave.kleikamp@oracle.com \
--cc=asias@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatlasov@parallels.com \
--cc=zab@zabbo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).