From: Jaegeuk Kim <jaegeuk.kim@samsung.com>
To: Namjae Jeon <linkinjeon@gmail.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
Namjae Jeon <namjae.jeon@samsung.com>,
Pankaj Kumar <pankaj.km@samsung.com>
Subject: Re: [PATCH 3/4] f2fs: introduce trace points in f2fs filesystem
Date: Mon, 14 Jan 2013 10:28:35 +0900 [thread overview]
Message-ID: <1358126915.22868.18.camel@kjgkr> (raw)
In-Reply-To: <1357969308-9361-1-git-send-email-linkinjeon@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2317 bytes --]
2013-01-12 (토), 14:41 +0900, Namjae Jeon:
> From: Namjae Jeon <namjae.jeon@samsung.com>
>
> #> cat /sys/kernel/debug/tracing/events/f2fs/enable
> 0
> #> echo 1 > /sys/kernel/debug/tracing/events/f2fs/enable
> #> cat /sys/kernel/debug/tracing/events/f2fs/enable
> 1
>
> #> mount -t f2fs /dev/sdb3 /mnt/
> #>
> #> cat /sys/kernel/debug/tracing/trace
> # tracer: nop
> #
> #TASK-PID CPU# TIMESTAMP FUNCTION
> # | | | | |
> mount-423 [001] 49.879188: f2fs_iget: dev 8,19 ino 2
> mount-423 [001] 49.879215: f2fs_get_page: dev 8,19 page_index 81, type 2
> mount-423 [001] 49.879224: f2fs_readpage: dev 8,19 ino 2 page_index 81
> mount-423 [001] 49.879819: f2fs_get_page: dev 8,19 page_index 83, type 2
> mount-423 [001] 49.879830: f2fs_readpage: dev 8,19 ino 2 page_index 83
> mount-423 [001] 49.880434: f2fs_get_page: dev 8,19 page_index 593, type 2
> mount-423 [001] 49.880442: f2fs_readpage: dev 8,19 ino 2 page_index 593
> mount-423 [001] 49.889931: f2fs_get_page: dev 8,19 page_index 595, type 2
> mount-423 [001] 49.889939: f2fs_readpage: dev 8,19 ino 2 page_index 595
> mount-423 [001] 49.892169: f2fs_get_page: dev 8,19 page_index 594, type 2
> mount-423 [001] 49.892186: f2fs_readpage: dev 8,19 ino 2 page_index 594
> ...
> ..
>
> Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> Signed-off-by: Pankaj Kumar <pankaj.km@samsung.com>
> ---
> fs/f2fs/checkpoint.c | 17 +
> fs/f2fs/data.c | 17 +
> fs/f2fs/file.c | 14 +
> fs/f2fs/inode.c | 10 +
> fs/f2fs/namei.c | 7 +-
> fs/f2fs/node.c | 23 +-
> fs/f2fs/segment.c | 5 +
> fs/f2fs/super.c | 4 +
> include/trace/events/f2fs.h | 1220 +++++++++++++++++++++++++++++++++++++++++++
IMO, it needs to split this patch into two independent patches like:
1. adding a header file to the event subsystem, and
2. introducing tracepoints in f2fs.
Then, we need to get acks from all the related maintainers.
Moreover, it is obvious that the patch-set should describe each of
tracepoints precisely and concretely.
Anyway, it must be a valuable job. :)
Thanks,
--
Jaegeuk Kim
Samsung
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-01-14 1:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-12 5:41 [PATCH 3/4] f2fs: introduce trace points in f2fs filesystem Namjae Jeon
2013-01-14 1:28 ` Jaegeuk Kim [this message]
2013-01-14 5:47 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1358126915.22868.18.camel@kjgkr \
--to=jaegeuk.kim@samsung.com \
--cc=linkinjeon@gmail.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namjae.jeon@samsung.com \
--cc=pankaj.km@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).