From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jaegeuk Kim Subject: Re: [PATCH 3/4] f2fs: introduce trace points in f2fs filesystem Date: Mon, 14 Jan 2013 10:28:35 +0900 Message-ID: <1358126915.22868.18.camel@kjgkr> References: <1357969308-9361-1-git-send-email-linkinjeon@gmail.com> Reply-To: jaegeuk.kim@samsung.com Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-hJPl6cNkln8jd6swOrS9" Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Namjae Jeon , Pankaj Kumar To: Namjae Jeon Return-path: In-reply-to: <1357969308-9361-1-git-send-email-linkinjeon@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org --=-hJPl6cNkln8jd6swOrS9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable 2013-01-12 (=ED=86=A0), 14:41 +0900, Namjae Jeon: > From: Namjae Jeon >=20 > #> cat /sys/kernel/debug/tracing/events/f2fs/enable > 0 > #> echo 1 > /sys/kernel/debug/tracing/events/f2fs/enable > #> cat /sys/kernel/debug/tracing/events/f2fs/enable > 1 >=20 > #> mount -t f2fs /dev/sdb3 /mnt/ > #> > #> cat /sys/kernel/debug/tracing/trace > # tracer: nop > # > #TASK-PID CPU# TIMESTAMP FUNCTION > # | | | | | > mount-423 [001] 49.879188: f2fs_iget: dev 8,19 ino 2 > mount-423 [001] 49.879215: f2fs_get_page: dev 8,19 page_index 81, = type 2 > mount-423 [001] 49.879224: f2fs_readpage: dev 8,19 ino 2 page_index= 81 > mount-423 [001] 49.879819: f2fs_get_page: dev 8,19 page_index 83, = type 2 > mount-423 [001] 49.879830: f2fs_readpage: dev 8,19 ino 2 page_index= 83 > mount-423 [001] 49.880434: f2fs_get_page: dev 8,19 page_index 593,= type 2 > mount-423 [001] 49.880442: f2fs_readpage: dev 8,19 ino 2 page_index= 593 > mount-423 [001] 49.889931: f2fs_get_page: dev 8,19 page_index 595,= type 2 > mount-423 [001] 49.889939: f2fs_readpage: dev 8,19 ino 2 page_index= 595 > mount-423 [001] 49.892169: f2fs_get_page: dev 8,19 page_index 594,= type 2 > mount-423 [001] 49.892186: f2fs_readpage: dev 8,19 ino 2 page_index= 594 > ... > .. >=20 > Signed-off-by: Namjae Jeon > Signed-off-by: Pankaj Kumar > --- > fs/f2fs/checkpoint.c | 17 + > fs/f2fs/data.c | 17 + > fs/f2fs/file.c | 14 + > fs/f2fs/inode.c | 10 + > fs/f2fs/namei.c | 7 +- > fs/f2fs/node.c | 23 +- > fs/f2fs/segment.c | 5 + > fs/f2fs/super.c | 4 + > include/trace/events/f2fs.h | 1220 +++++++++++++++++++++++++++++++++++++= ++++++ IMO, it needs to split this patch into two independent patches like: 1. adding a header file to the event subsystem, and 2. introducing tracepoints in f2fs. Then, we need to get acks from all the related maintainers. Moreover, it is obvious that the patch-set should describe each of tracepoints precisely and concretely. Anyway, it must be a valuable job. :) Thanks, --=20 Jaegeuk Kim Samsung --=-hJPl6cNkln8jd6swOrS9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAABAgAGBQJQ819DAAoJEEAUqH6CSFDSGQkP/jdbJEaEDdWuxgDYkNM0a4Ck djCIAeHAZnAJOIsxlImluM+5/K5osE6fKT2bHor1GMf7wZnkYfpLnVJYWe0vtKdM TuXTsR0hzGWPwm76a0n6WmKUL6tVbWMls+BSfZN0uhRfS0H1hRx4hafL4EMB+9pF +q3pvHi7dzJvQVOLO1vgW2Po0rWi8+Df0IKHmiJJ+6iu1m5jYaG2VLB+nKWQ5RTW VT2BblH1pAWNP7+HvtTV95QY8ypc25aBx/AwslzAsrMhvozssjvHJ5AOoVg0NSVE ugeyW+aAkz69bi+jYwwYDHBp/Lqtkl+1rxTD9oV2ThC+eHr7WvIjx3iW7mltjmUW hnC6jtT5zH1EoJh5KpMprXmmSCzx0OmB2vQTTle+6Hy3EWOdVr4u6FUIGrfTeXKD eI8pJ5Syf8yVCT804UQeADZq2StzM/jwCVkCqbp1hAhHq5zg2R7VreEFOv7798Kd M/FX3i7tbK8bR6FRG9t0fpmdXVAGBPntPARJ0WnWNnqYHhaZOqxKUlXjjocFax0q k4UBrpgAux+M+h/eaSXamQq3zgYz1N13bkrNFF/msS/a9RdQTfW14Ten+bwh/R6B r1SFqCms1UX+QJHRuIbNdbBzrMcQLfkUzfl+90koRzHEiVD7sPsx6zdaJnsdclcF R/P+xsVSFR+tMIoemYWc =yVFW -----END PGP SIGNATURE----- --=-hJPl6cNkln8jd6swOrS9--