From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jaegeuk Kim Subject: Re: [PATCH] f2fs:avoid creaing multi debugfs when mount more disks. Date: Tue, 15 Jan 2013 21:10:27 +0900 Message-ID: <1358251827.8234.67.camel@kjgkr> References: <201301141929076532360@gmail.com> <1358233688.8234.50.camel@kjgkr> <1358249380.8234.60.camel@kjgkr> Reply-To: jaegeuk.kim@samsung.com Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-9JSKA6EgBYXvoF5mjziz" Cc: majianpeng , linux-f2fs-devel , linux-fsdevel To: Namjae Jeon Return-path: Received: from mailout2.samsung.com ([203.254.224.25]:47180 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753565Ab3AOMKb (ORCPT ); Tue, 15 Jan 2013 07:10:31 -0500 Received: from epcpsbgm1.samsung.com (epcpsbgm1 [203.254.230.26]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MGO0028B1TARU40@mailout2.samsung.com> for linux-fsdevel@vger.kernel.org; Tue, 15 Jan 2013 21:10:30 +0900 (KST) Received: from [12.52.126.105] by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MGO004VD1TIM4B0@mmp2.samsung.com> for linux-fsdevel@vger.kernel.org; Tue, 15 Jan 2013 21:10:30 +0900 (KST) In-reply-to: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: --=-9JSKA6EgBYXvoF5mjziz Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable 2013-01-15 (=ED=99=94), 20:50 +0900, Namjae Jeon: > 2013/1/15, Jaegeuk Kim : > > [snip] > > > >> void f2fs_destroy_stats(struct f2fs_sb_info *sbi) > >> { > >> struct f2fs_stat_info *si =3D sbi->stat_info; > >> @@ -354,7 +339,15 @@ void f2fs_destroy_stats(struct f2fs_sb_info *sbi) > >> kfree(sbi->stat_info); > >> } > >> > >> -void destroy_root_stats(void) > >> +void __init f2fs_create_root_stats(void) > > > > We don't need to add __init here, right? > As you know, the function f2fs_create_root_stats will only be needed > at the init time of F2FS filesystem. So, there is no harm making this > function part of __init section, as this function will never be called > again. Oh, I meant it for code consistency at this moment. No other functions declare that though. Do we need to write another patch to add __init globally? > Thanks. > > Anyway, this patch looks much better to me. > > > > Jianpeng, how do you think about this? > > > > -- > > Jaegeuk Kim > > Samsung > > --=20 Jaegeuk Kim Samsung --=-9JSKA6EgBYXvoF5mjziz Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAABAgAGBQJQ9UczAAoJEEAUqH6CSFDSHh4P/RPiS2SiLmGGkKK5UqVK9CUI S0m9LqPy3MOs1d2TQknDTMAGBxCLINFj7u9RUzMegs+m0MV2LclQ4Wd30gKw2Hlu ds8hdUXWQKjGQ7R3GFptRoSRfltpLuNTBZF9dLxcGrY00riIRT6P4NXn4IrwtKzM +zTkLewx6g15WnKag5CAqc728PnvfvOIdpHZvnCHUIS8Lam9NIizIrbgKq0PbdWz 0e3F/n0gB3yDIhQrgrOmwb8+ziU//gGqG8xNC2v5THuro4EsrIwXvFmfvzVvg624 AUtuPoxADtrnLphgnokISKH6YSbICEEopO7b9ekrUfShV+29gg196ugQMI8HeiaA Eci3qP2TeKm8OupC80UZ6/1g5VUyiRRD2hpASTcaVrz556qNphNo8AmW+aLGUAck Mld4c1ZkxFtB++HMk2IPgl3aIHvnF7HaVhAQ14mCf3VHQNhW2xO46isq/LCj2se5 GIbDoENctllVR3fqONlYmOJWnzOUS5pkvc6SsO2uzkLAsdq30P1Ha7OHjV4f+IjE nW3Rk13KF/yvqojM3IN49sEaP9CQnUf70bIddHf79iyy/cUWmVMoBtM0Brk7amEe uGGSFW7nU6FOPV7dHwNnxe3gqeSEuCFUIgq2vdu9vTJtiY+ZQY/rDJyfs+lc2SWG XsXhegOthjoxXntgUQ9t =COWv -----END PGP SIGNATURE----- --=-9JSKA6EgBYXvoF5mjziz--