From: Sedat Dilek <sedat.dilek@gmail.com>
To: Dave Kleikamp <dave.kleikamp@oracle.com>,
Zach Brown <zab@zabbo.net>,
"Maxim V. Patlasov" <mpatlasov@parallels.com>
Cc: Sedat Dilek <sedat.dilek@gmail.com>,
Jeff Moyer <jmoyer@redhat.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org
Subject: [PATCH loop_2013_01_04] fs: Fix a typo in aio_rw_vect_retry()
Date: Tue, 22 Jan 2013 02:47:31 +0100 [thread overview]
Message-ID: <1358819251-3355-1-git-send-email-sedat.dilek@gmail.com> (raw)
Dave confirmed Jeff's suspicion in [1]:
>> That wants to be rw_op = do_aio_write in the else clause. How did you
>> test this patch set?
> Yep, that's certainly a bug. I concentrated on testing on loop mounts,
> running some fio and ltp testcases, but I'm at a loss to explain how
> things seem to work as well as they do. Let's see how where fixing this
> leads.
This is a fixup to commit daf0f6142dd5 ("fs: use read_iter and write_iter
rather than aio_read and aio_write") from Dave Kleikamp's GIT tree in [2].
[1] http://www.spinics.net/lists/linux-fsdevel/msg61587.html
[2] https://github.com/kleikamp/linux-shaggy/commits/loop_2013_01_04
Cc: Dave Kleikamp <dave.kleikamp@oracle.com>
Cc: Jeff Moyer <jmoyer@redhat.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org
[ v2: Misspelled Dave's last name and fix quoting. ]
Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
---
fs/aio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/aio.c b/fs/aio.c
index 08f550a..9635e7a 100644
--- a/fs/aio.c
+++ b/fs/aio.c
@@ -1320,7 +1320,7 @@ static ssize_t aio_rw_vect_retry(struct kiocb *iocb)
rw_op = do_aio_read;
opcode = IOCB_CMD_PREADV;
} else {
- rw_op = do_aio_read;
+ rw_op = do_aio_write;
opcode = IOCB_CMD_PWRITEV;
}
--
1.8.1.1
next reply other threads:[~2013-01-22 1:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-22 1:47 Sedat Dilek [this message]
2013-01-22 11:41 ` [PATCH loop_2013_01_04] fs: Fix a typo in aio_rw_vect_retry() Carlos Maiolino
-- strict thread matches above, loose matches on Subject: below --
2013-01-22 1:11 Sedat Dilek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1358819251-3355-1-git-send-email-sedat.dilek@gmail.com \
--to=sedat.dilek@gmail.com \
--cc=dave.kleikamp@oracle.com \
--cc=jmoyer@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mpatlasov@parallels.com \
--cc=viro@zeniv.linux.org.uk \
--cc=zab@zabbo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).