linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: linux-fsdevel@vger.kernel.org
Cc: tytso@mit.edu, bpm@sgi.com, jlbec@evilplan.org,
	Jan Kara <jack@suse.cz>,
	ocfs2-devel@oss.oracle.com, stable@vger.kernel.org
Subject: [PATCH 3/4] ocfs2: Fix possible use-after-free with AIO
Date: Wed, 23 Jan 2013 13:56:19 +0100	[thread overview]
Message-ID: <1358945780-23661-4-git-send-email-jack@suse.cz> (raw)
In-Reply-To: <1358945780-23661-1-git-send-email-jack@suse.cz>

Running AIO is pinning inode in memory using file reference. Once AIO
is completed using aio_complete(), file reference is put and inode can
be freed from memory. So we have to be sure that calling aio_complete()
is the last thing we do with the inode.

CC: Joel Becker <jlbec@evilplan.org>
CC: ocfs2-devel@oss.oracle.com
CC: stable@vger.kernel.org
Signed-off-by: Jan Kara <jack@suse.cz>
---
 fs/ocfs2/aops.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/ocfs2/aops.c b/fs/ocfs2/aops.c
index 6577432..340bd02 100644
--- a/fs/ocfs2/aops.c
+++ b/fs/ocfs2/aops.c
@@ -593,9 +593,9 @@ static void ocfs2_dio_end_io(struct kiocb *iocb,
 	level = ocfs2_iocb_rw_locked_level(iocb);
 	ocfs2_rw_unlock(inode, level);
 
+	inode_dio_done(inode);
 	if (is_async)
 		aio_complete(iocb, ret, 0);
-	inode_dio_done(inode);
 }
 
 /*
-- 
1.7.1


  parent reply	other threads:[~2013-01-23 12:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-23 12:56 [PATCH 0/4] Fix possible use after free with AIO Jan Kara
2013-01-23 12:56 ` [PATCH 1/4] ext4: Fix possible use-after-free " Jan Kara
2013-01-23 13:18   ` Carlos Maiolino
2013-01-23 12:56 ` [PATCH 2/4] xfs: " Jan Kara
2013-01-23 22:00   ` Ben Myers
2013-01-23 12:56 ` Jan Kara [this message]
2013-01-23 12:56 ` [PATCH 4/4] fs: " Jan Kara
2013-01-23 15:02   ` Jeff Moyer
2013-01-23 19:18     ` Jan Kara
2013-01-23 16:03 ` [PATCH 0/4] Fix possible use after free " Jeff Moyer
  -- strict thread matches above, loose matches on Subject: below --
2013-01-29 23:27 [PATCH 0/4 v2] " Jan Kara
2013-01-29 23:28 ` [PATCH 3/4] ocfs2: Fix possible use-after-free " Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1358945780-23661-4-git-send-email-jack@suse.cz \
    --to=jack@suse.cz \
    --cc=bpm@sgi.com \
    --cc=jlbec@evilplan.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=ocfs2-devel@oss.oracle.com \
    --cc=stable@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).