From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To: Andrea Arcangeli <aarcange@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Al Viro <viro@zeniv.linux.org.uk>
Cc: Wu Fengguang <fengguang.wu@intel.com>, Jan Kara <jack@suse.cz>,
Mel Gorman <mgorman@suse.de>,
linux-mm@kvack.org, Andi Kleen <ak@linux.intel.com>,
Matthew Wilcox <matthew.r.wilcox@intel.com>,
"Kirill A. Shutemov" <kirill@shutemov.name>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Subject: [PATCH, RFC 08/16] thp, mm: locking tail page is a bug
Date: Mon, 28 Jan 2013 11:24:20 +0200 [thread overview]
Message-ID: <1359365068-10147-9-git-send-email-kirill.shutemov@linux.intel.com> (raw)
In-Reply-To: <1359365068-10147-1-git-send-email-kirill.shutemov@linux.intel.com>
From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
---
mm/filemap.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/mm/filemap.c b/mm/filemap.c
index a4b4fd5..f59eaa1 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -665,6 +665,7 @@ void __lock_page(struct page *page)
{
DEFINE_WAIT_BIT(wait, &page->flags, PG_locked);
+ VM_BUG_ON(PageTail(page));
__wait_on_bit_lock(page_waitqueue(page), &wait, sleep_on_page,
TASK_UNINTERRUPTIBLE);
}
@@ -674,6 +675,7 @@ int __lock_page_killable(struct page *page)
{
DEFINE_WAIT_BIT(wait, &page->flags, PG_locked);
+ VM_BUG_ON(PageTail(page));
return __wait_on_bit_lock(page_waitqueue(page), &wait,
sleep_on_page_killable, TASK_KILLABLE);
}
--
1.7.10.4
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-01-28 9:24 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-28 9:24 [PATCH, RFC 00/16] Transparent huge page cache Kirill A. Shutemov
2013-01-28 9:24 ` [PATCH, RFC 01/16] block: implement add_bdi_stat() Kirill A. Shutemov
2013-01-28 9:24 ` [PATCH, RFC 02/16] mm: implement zero_huge_user_segment and friends Kirill A. Shutemov
2013-01-28 9:24 ` [PATCH, RFC 03/16] mm: drop actor argument of do_generic_file_read() Kirill A. Shutemov
2013-01-28 9:24 ` [PATCH, RFC 04/16] radix-tree: implement preload for multiple contiguous elements Kirill A. Shutemov
2013-01-28 9:24 ` [PATCH, RFC 05/16] thp, mm: basic defines for transparent huge page cache Kirill A. Shutemov
2013-01-28 9:24 ` [PATCH, RFC 06/16] thp, mm: rewrite add_to_page_cache_locked() to support huge pages Kirill A. Shutemov
2013-01-29 12:11 ` Hillf Danton
2013-01-29 13:01 ` Kirill A. Shutemov
2013-01-29 12:14 ` Hillf Danton
2013-01-29 12:26 ` Hillf Danton
2013-01-29 12:48 ` Kirill A. Shutemov
2013-01-28 9:24 ` [PATCH, RFC 07/16] thp, mm: rewrite delete_from_page_cache() " Kirill A. Shutemov
2013-01-28 9:24 ` Kirill A. Shutemov [this message]
2013-01-28 9:24 ` [PATCH, RFC 09/16] thp, mm: handle tail pages in page_cache_get_speculative() Kirill A. Shutemov
2013-01-28 9:24 ` [PATCH, RFC 10/16] thp, mm: implement grab_cache_huge_page_write_begin() Kirill A. Shutemov
2013-01-28 9:24 ` [PATCH, RFC 11/16] thp, mm: naive support of thp in generic read/write routines Kirill A. Shutemov
2013-01-28 9:24 ` [PATCH, RFC 12/16] thp, libfs: initial support of thp in simple_read/write_begin/write_end Kirill A. Shutemov
2013-01-28 9:24 ` [PATCH, RFC 13/16] thp: handle file pages in split_huge_page() Kirill A. Shutemov
2013-01-28 9:24 ` [PATCH, RFC 14/16] thp, mm: truncate support for transparent huge page cache Kirill A. Shutemov
2013-01-28 9:24 ` [PATCH, RFC 15/16] thp, mm: split huge page on mmap file page Kirill A. Shutemov
2013-01-28 9:24 ` [PATCH, RFC 16/16] ramfs: enable transparent huge page cache Kirill A. Shutemov
2013-01-29 5:03 ` [PATCH, RFC 00/16] Transparent " Hugh Dickins
2013-01-29 13:14 ` Kirill A. Shutemov
2013-01-31 2:12 ` Hugh Dickins
2013-02-02 15:13 ` Kirill A. Shutemov
2013-04-05 0:26 ` Simon Jeons
2013-04-05 1:03 ` Simon Jeons
2013-04-05 1:42 ` Wanpeng Li
[not found] ` <20130405014208.GC362@hacker.(null)>
2013-04-07 0:26 ` Wanpeng Li
2013-04-05 1:24 ` Ric Mason
2013-03-18 9:36 ` Simon Jeons
2013-03-21 8:00 ` Simon Jeons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359365068-10147-9-git-send-email-kirill.shutemov@linux.intel.com \
--to=kirill.shutemov@linux.intel.com \
--cc=aarcange@redhat.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=jack@suse.cz \
--cc=kirill@shutemov.name \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=matthew.r.wilcox@intel.com \
--cc=mgorman@suse.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).