f2fs backport and typo fix

f2fs backport and typo fix

[Alejandro Martinez Ruiz]

Hi,

I recently ported f2fs to kernel 3.2, but I am not sure whether the changes are
all OK. If so, that could be useful to a number of projects, and I'd very much
appreciate any help in reviewing and looking for possible errors or omissions,
specially those related to VFS.

You can check the 3.2 kernel patches in http://github.com/nowcomputing/f2fs-backports.

Additionally, I just noticed a typo in f2fs options. Here's a patch for use with
git am --scissors.

Thanks,
  Alex

-- >8 --
From: Alejandro Martinez Ruiz <alex@nowcomputing.com>
Date: Fri, 25 Jan 2013 19:08:59 +0100
Subject: [PATCH] f2fs: fix disable_ext_identify option spelling

There is a typo in the ->show_options function for disable_ext_identify.
Fix it to match the spelling from the documentation.

Signed-off-by: Alejandro Martinez Ruiz <alex@nowcomputing.com>
---
 fs/f2fs/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 117ca2a..25656b6 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -198,7 +198,7 @@ static int f2fs_show_options(struct seq_file *seq, struct dentry *root)
 		seq_puts(seq, ",noacl");
 #endif
 	if (test_opt(sbi, DISABLE_EXT_IDENTIFY))
-		seq_puts(seq, ",disable_ext_indentify");
+		seq_puts(seq, ",disable_ext_identify");
 
 	seq_printf(seq, ",active_logs=%u", sbi->active_logs);
 
-- 
1.8.1.rc1.17.g75ed918

Re: f2fs backport and typo fix

[Jaegeuk Kim]

[-- Attachment #1: Type: text/plain, Size: 1466 bytes --]

Hi,

2013-01-28 (월), 13:11 +0100, Alejandro Martinez Ruiz:
> Hi,
> 
> I recently ported f2fs to kernel 3.2, but I am not sure whether the changes are
> all OK. If so, that could be useful to a number of projects, and I'd very much
> appreciate any help in reviewing and looking for possible errors or omissions,
> specially those related to VFS.

Great job. Thank you for the work.
BTW, as I see your patches in the repo, it would be better to modify the
following patch.
Except this, everything looks good to me at a glance.

0002-vfs-export-symbol-d_find_any_alias.patch
 - Let's avoid modifying the kernel core.

@@ -104,19 +102,14 @@ static int need_to_sync_dir(struct f2fs_sb_info
*sbi, struct inode *inode)
        struct dentry *dentry;
        nid_t pino;
 
-       inode = igrab(inode);
-       dentry = d_find_any_alias(inode);
-       if (!dentry) {
-               iput(inode);
+       dentry = list_entry(inode->i_dentry.next, struct dentry,
d_alias);
+       if (!dentry)
                return 0;
-       }
        pino = dentry->d_parent->d_inode->i_ino;
-       dput(dentry);
-       iput(inode);
        return !is_checkpointed_node(sbi, pino);
 }

> 
> You can check the 3.2 kernel patches in http://github.com/nowcomputing/f2fs-backports.
> 
> Additionally, I just noticed a typo in f2fs options. Here's a patch for use with
> git am --scissors.

Applied, thank you~ :)

-- 
Jaegeuk Kim
Samsung

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: f2fs backport and typo fix

[Alejandro Martinez]

Hi,

On Tue, Jan 29, 2013 at 12:43 PM, Jaegeuk Kim <jaegeuk.kim@samsung.com> wrote:
> Great job. Thank you for the work.
> BTW, as I see your patches in the repo, it would be better to modify the
> following patch.
> Except this, everything looks good to me at a glance.
>
> 0002-vfs-export-symbol-d_find_any_alias.patch
>  - Let's avoid modifying the kernel core.
>
> @@ -104,19 +102,14 @@ static int need_to_sync_dir(struct f2fs_sb_info
> *sbi, struct inode *inode)
>         struct dentry *dentry;
>         nid_t pino;
>
> -       inode = igrab(inode);
> -       dentry = d_find_any_alias(inode);
> -       if (!dentry) {
> -               iput(inode);
> +       dentry = list_entry(inode->i_dentry.next, struct dentry,
> d_alias);
> +       if (!dentry)
>                 return 0;
> -       }
>         pino = dentry->d_parent->d_inode->i_ino;
> -       dput(dentry);
> -       iput(inode);
>         return !is_checkpointed_node(sbi, pino);
>  }
>

I initially thought exporting a symbol was not a big deal, but it is
certainly not the right thing to do. I very much prefer your patch.
Fixed now, thanks for your input!

  Alex