Re: f2fs backport and typo fix

[Jaegeuk Kim <jaegeuk.kim@samsung.com>]

[-- Attachment #1: Type: text/plain, Size: 1466 bytes --]

Hi,

2013-01-28 (월), 13:11 +0100, Alejandro Martinez Ruiz:
> Hi,
> 
> I recently ported f2fs to kernel 3.2, but I am not sure whether the changes are
> all OK. If so, that could be useful to a number of projects, and I'd very much
> appreciate any help in reviewing and looking for possible errors or omissions,
> specially those related to VFS.

Great job. Thank you for the work.
BTW, as I see your patches in the repo, it would be better to modify the
following patch.
Except this, everything looks good to me at a glance.

0002-vfs-export-symbol-d_find_any_alias.patch
 - Let's avoid modifying the kernel core.

@@ -104,19 +102,14 @@ static int need_to_sync_dir(struct f2fs_sb_info
*sbi, struct inode *inode)
        struct dentry *dentry;
        nid_t pino;
 
-       inode = igrab(inode);
-       dentry = d_find_any_alias(inode);
-       if (!dentry) {
-               iput(inode);
+       dentry = list_entry(inode->i_dentry.next, struct dentry,
d_alias);
+       if (!dentry)
                return 0;
-       }
        pino = dentry->d_parent->d_inode->i_ino;
-       dput(dentry);
-       iput(inode);
        return !is_checkpointed_node(sbi, pino);
 }

> 
> You can check the 3.2 kernel patches in http://github.com/nowcomputing/f2fs-backports.
> 
> Additionally, I just noticed a typo in f2fs options. Here's a patch for use with
> git am --scissors.

Applied, thank you~ :)

-- 
Jaegeuk Kim
Samsung

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]