From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jaegeuk Kim Subject: Re: f2fs backport and typo fix Date: Tue, 29 Jan 2013 20:43:23 +0900 Message-ID: <1359459803.22847.51.camel@kjgkr> References: <1359375114-6269-1-git-send-email-alex@nowcomputing.com> Reply-To: jaegeuk.kim@samsung.com Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-OE4nKmmWdST8tPYPTBDK" Cc: linux-fsdevel@vger.kernel.org To: Alejandro Martinez Ruiz Return-path: Received: from mailout3.samsung.com ([203.254.224.33]:25535 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754966Ab3A2Lnt (ORCPT ); Tue, 29 Jan 2013 06:43:49 -0500 Received: from epcpsbgm2.samsung.com (epcpsbgm2 [203.254.230.27]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MHD00H9NXWPVS31@mailout3.samsung.com> for linux-fsdevel@vger.kernel.org; Tue, 29 Jan 2013 20:43:47 +0900 (KST) Received: from [12.52.126.105] by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MHD00K2CXWZPI80@mmp2.samsung.com> for linux-fsdevel@vger.kernel.org; Tue, 29 Jan 2013 20:43:47 +0900 (KST) In-reply-to: <1359375114-6269-1-git-send-email-alex@nowcomputing.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: --=-OE4nKmmWdST8tPYPTBDK Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, 2013-01-28 (=EC=9B=94), 13:11 +0100, Alejandro Martinez Ruiz: > Hi, >=20 > I recently ported f2fs to kernel 3.2, but I am not sure whether the chang= es are > all OK. If so, that could be useful to a number of projects, and I'd very= much > appreciate any help in reviewing and looking for possible errors or omiss= ions, > specially those related to VFS. Great job. Thank you for the work. BTW, as I see your patches in the repo, it would be better to modify the following patch. Except this, everything looks good to me at a glance. 0002-vfs-export-symbol-d_find_any_alias.patch - Let's avoid modifying the kernel core. @@ -104,19 +102,14 @@ static int need_to_sync_dir(struct f2fs_sb_info *sbi, struct inode *inode) struct dentry *dentry; nid_t pino; =20 - inode =3D igrab(inode); - dentry =3D d_find_any_alias(inode); - if (!dentry) { - iput(inode); + dentry =3D list_entry(inode->i_dentry.next, struct dentry, d_alias); + if (!dentry) return 0; - } pino =3D dentry->d_parent->d_inode->i_ino; - dput(dentry); - iput(inode); return !is_checkpointed_node(sbi, pino); } >=20 > You can check the 3.2 kernel patches in http://github.com/nowcomputing/f2= fs-backports. >=20 > Additionally, I just noticed a typo in f2fs options. Here's a patch for u= se with > git am --scissors. Applied, thank you~ :) --=20 Jaegeuk Kim Samsung --=-OE4nKmmWdST8tPYPTBDK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAABAgAGBQJRB7XcAAoJEEAUqH6CSFDS0KIP/2/SpQt743so/R+lZE+IKz4H andU6V7defqdqEQ4n1bPE8H00nSAR4Gsv6I8BXyHyEyzjRMhxxX5sW0SZI4Qsa62 xI8QLVxVUH0Y1LsqQQOmJif/osLwrWAdrq8Sqmod01e+q/Aglo/CBIbgQbwY+1tp G48AipBSZ7FEDMDnrBbybFcHfFxUK03adL/DXk1hBkSPVHhdpCJELevjWHjg6Jgr tSJ/D3fqNPcc6og10lZCnXbIE1UKB+UiNXoLcVoHRz4hH8lIF8hOuSdZ/AWEQV7y QflZFtvSsGCoEuXZeM8mnO2kCCecY8HW8ykQMnfZRGn+xxwsFqO3gt8BCZfsxVM+ jDTxpYEbTmsR+50cdrxahGXqDlRWIYxXBZs0Mr9Z1G8WW8LGBm6DeIg89e/5xH2g /WgiKT19OE1XBw93ua7VRJjh+14yCbWVbj2ae3vM5ooUg3Y8r5+xIFXkEGTWV38c UXl2496QkWfYeaZpCKsIQlgOFs+ytXj5OvUDBM/SQyUfDwqt2NIoGKid+kpx1IJj X/XgAoTPV/M1B2FjGt2cqOYhijUbXwUz7CRlOC/bExiuf2zzxkgsgFOKMgP7wB6A COIa8MvJXz5OSO/80C30WPurq1G9cd0nnCoQod08kT5DRq8ui6BJMNXFTmrnoc8Z bHahBSIkeO2FEX/6pG44 =vS8m -----END PGP SIGNATURE----- --=-OE4nKmmWdST8tPYPTBDK--