From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jaegeuk Kim Subject: Re: [PATCH 1/3] f2fs: avoid redundant call to has_not_enough_free_secs in f2fs_gc Date: Thu, 31 Jan 2013 10:03:52 +0900 Message-ID: <1359594232.22847.56.camel@kjgkr> References: <1359553622-7449-1-git-send-email-linkinjeon@gmail.com> Reply-To: jaegeuk.kim@samsung.com Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-VJBL4LQoxHv3WN4ixRL2" Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Namjae Jeon , Amit Sahrawat To: Namjae Jeon Return-path: Received: from mailout4.samsung.com ([203.254.224.34]:26907 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753809Ab3AaBET (ORCPT ); Wed, 30 Jan 2013 20:04:19 -0500 In-reply-to: <1359553622-7449-1-git-send-email-linkinjeon@gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: --=-VJBL4LQoxHv3WN4ixRL2 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable 2013-01-30 (=EC=88=98), 22:47 +0900, Namjae Jeon: > From: Namjae Jeon >=20 > After doing a write_checkpoint from garbage collection path if there is s= till > need to do more garbage collection, gc_more label is used to jump and sta= rt > the process again. And in that process, first step before getting victim = is to > check if there are not enough free sections, which is already done before > doing a jump to gc_more. We can avoid the redundant call to check free > sections, by checking the gc_type flag which will remain FG_GC(value 1) u= nder > this condition. >=20 > Signed-off-by: Namjae Jeon > Signed-off-by: Amit Sahrawat > --- > fs/f2fs/gc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c > index 9b5d0aa..0dfdaa5 100644 > --- a/fs/f2fs/gc.c > +++ b/fs/f2fs/gc.c > @@ -672,7 +672,7 @@ gc_more: > if (!(sbi->sb->s_flags & MS_ACTIVE)) > goto stop; > =20 > - if (has_not_enough_free_secs(sbi)) > + if (!gc_type && has_not_enough_free_secs(sbi)) I applied this patch with the following change: if (gc_type =3D=3D BG_GC && has_not_enough_free_secs(sbi)) Thank you. :) > gc_type =3D FG_GC; > =20 > if (!__get_victim(sbi, &segno, gc_type, NO_CHECK_TYPE)) --=20 Jaegeuk Kim Samsung --=-VJBL4LQoxHv3WN4ixRL2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAABAgAGBQJRCcL4AAoJEEAUqH6CSFDSzYsP/i21IsgXkU0CQPcevFl0jdiG u4QucScGJTHQZzfilfG+bBMl1tGIcePAMpWJF57wSUnsD4kjkIRqGCh91T61ktUU fpa8Fr/dtiA/RO7ZxQ626VJmcRPV1Bjjized7SGE/9Wlb+/4Zzsiq7b/i10iM80y KEhDb/fVcFMN59UvkM8u+r//VXxSG+qBANDHbr8doeszveLFkVab/84M2NVpFWvk cX261q0sgP83/qEgi+dXDpr+ZAZkpTqXmc4IdJo89cnCc2kfHBD5Z6/p1EfztC+p Izffe2bEllrnCqftSj2rh4YSpKiFAXcOGCyWT6isiuZ0Ez6GTu/yaRTrTg1AUyIW 0uZF0vmBqfpn4bkppq+FMIx1gYgywu/+sBWQYGEDNTwgFmtHpMGcKUeGMvuho4Ab R13MAp4Xme912aXmhtWcKGReVertga/sjZS9/tXEvwZ0WFZo6tWxFxPjmXx16r65 LPI4s9nkgWVi8maZsolbnAtNjn7KtvVYk93MRHSLrGY0WSnZx6bKSIfAGTmu5+T7 a3uclzGtw/83VE8Jj9RQ1L943G5V1M+dDTpon2qENxP/LQi7HIKTCUz77MicHyVf hOZWNYmouAM0wFsbn5c31gz45+yKAErwCuNhgjwVIHk/77uKdp6JU9GmPtEYurq5 oDBncDHJQhZjye6aPPpy =OWPt -----END PGP SIGNATURE----- --=-VJBL4LQoxHv3WN4ixRL2--