From: Lin Feng <linfeng@cn.fujitsu.com>
To: akpm@linux-foundation.org, mgorman@suse.de, bcrl@kvack.org,
viro@zeniv.linux.org.uk
Cc: khlebnikov@openvz.org, walken@google.com,
kamezawa.hiroyu@jp.fujitsu.com, minchan@kernel.org,
riel@redhat.com, rientjes@google.com,
isimatu.yasuaki@jp.fujitsu.com, wency@cn.fujitsu.com,
laijs@cn.fujitsu.com, jiang.liu@huawei.com, linux-mm@kvack.org,
linux-aio@kvack.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, Lin Feng <linfeng@cn.fujitsu.com>
Subject: [PATCH 2/2] fs/aio.c: use get_user_pages_non_movable() to pin ring pages when support memory hotremove
Date: Mon, 4 Feb 2013 18:04:08 +0800 [thread overview]
Message-ID: <1359972248-8722-3-git-send-email-linfeng@cn.fujitsu.com> (raw)
In-Reply-To: <1359972248-8722-1-git-send-email-linfeng@cn.fujitsu.com>
This patch gets around the aio ring pages can't be migrated bug caused by
get_user_pages() via using the new function. It only works as configed with
CONFIG_MEMORY_HOTREMOVE, otherwise it uses the old version of get_user_pages().
Cc: Benjamin LaHaise <bcrl@kvack.org>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: Tang Chen <tangchen@cn.fujitsu.com>
Reviewed-by: Gu Zheng <guz.fnst@cn.fujitsu.com>
Signed-off-by: Lin Feng <linfeng@cn.fujitsu.com>
---
fs/aio.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/fs/aio.c b/fs/aio.c
index 71f613c..0e9b30a 100644
--- a/fs/aio.c
+++ b/fs/aio.c
@@ -138,9 +138,15 @@ static int aio_setup_ring(struct kioctx *ctx)
}
dprintk("mmap address: 0x%08lx\n", info->mmap_base);
+#ifdef CONFIG_MEMORY_HOTREMOVE
+ info->nr_pages = get_user_pages_non_movable(current, ctx->mm,
+ info->mmap_base, nr_pages,
+ 1, 0, info->ring_pages, NULL);
+#else
info->nr_pages = get_user_pages(current, ctx->mm,
info->mmap_base, nr_pages,
1, 0, info->ring_pages, NULL);
+#endif
up_write(&ctx->mm->mmap_sem);
if (unlikely(info->nr_pages != nr_pages)) {
--
1.7.11.7
--
To unsubscribe, send a message with 'unsubscribe linux-aio' in
the body to majordomo@kvack.org. For more info on Linux AIO,
see: http://www.kvack.org/aio/
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
next prev parent reply other threads:[~2013-02-04 10:04 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-04 10:04 [PATCH 0/2] mm: hotplug: implement non-movable version of get_user_pages() to kill long-time pin pages Lin Feng
2013-02-04 10:04 ` [PATCH 1/2] mm: hotplug: implement non-movable version of get_user_pages() called get_user_pages_non_movable() Lin Feng
2013-02-05 0:06 ` Andrew Morton
2013-02-05 0:18 ` Andrew Morton
2013-02-05 3:09 ` Lin Feng
2013-02-05 21:13 ` Andrew Morton
2013-02-05 11:57 ` Mel Gorman
2013-02-05 13:32 ` Mel Gorman
2013-02-19 13:37 ` Lin Feng
2013-02-20 2:34 ` Lin Feng
2013-02-20 2:44 ` Wanpeng Li
2013-02-20 2:44 ` Wanpeng Li
[not found] ` <20130220024435.GA30208@hacker.(null)>
2013-02-20 2:59 ` Lin Feng
2013-02-20 9:58 ` Simon Jeons
2013-02-20 10:23 ` Lin Feng
2013-02-20 11:31 ` Simon Jeons
2013-02-20 11:54 ` Lin Feng
2013-02-06 2:26 ` Michel Lespinasse
2013-02-06 10:41 ` Mel Gorman
2013-02-18 10:34 ` Lin Feng
2013-02-18 15:17 ` Mel Gorman
2013-02-19 9:55 ` Lin Feng
2013-02-19 10:34 ` Mel Gorman
2013-02-04 10:04 ` Lin Feng [this message]
2013-02-04 15:18 ` [PATCH 2/2] fs/aio.c: use get_user_pages_non_movable() to pin ring pages when support memory hotremove Jeff Moyer
2013-02-04 23:02 ` Zach Brown
2013-02-05 5:35 ` Lin Feng
2013-02-05 5:06 ` Lin Feng
2013-02-05 0:58 ` [PATCH 0/2] mm: hotplug: implement non-movable version of get_user_pages() to kill long-time pin pages Minchan Kim
2013-02-05 4:42 ` Lin Feng
2013-02-05 5:25 ` Minchan Kim
2013-02-05 6:18 ` Lin Feng
2013-02-05 7:45 ` Minchan Kim
2013-02-05 8:27 ` Lin Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359972248-8722-3-git-send-email-linfeng@cn.fujitsu.com \
--to=linfeng@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=bcrl@kvack.org \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=jiang.liu@huawei.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=khlebnikov@openvz.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=minchan@kernel.org \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=viro@zeniv.linux.org.uk \
--cc=walken@google.com \
--cc=wency@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).