* [PATCH] f2fs: add compat_ioctl to provide backward compatability
@ 2013-02-04 14:41 Namjae Jeon
2013-02-05 5:28 ` Namjae Jeon
0 siblings, 1 reply; 6+ messages in thread
From: Namjae Jeon @ 2013-02-04 14:41 UTC (permalink / raw)
To: jaegeuk.kim
Cc: linux-fsdevel, linux-kernel, linux-f2fs-devel, Namjae Jeon,
Namjae Jeon, Amit Sahrawat
From: Namjae Jeon <namjae.jeon@samsung.com>
adding compat_ioctl to provide support for backward comptability - 32bit binary
execution on 64bit kernel.
Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: Amit Sahrawat <a.sahrawat@samsung.com>
---
fs/f2fs/f2fs.h | 15 +++++++++++++++
fs/f2fs/file.c | 20 ++++++++++++++++++++
2 files changed, 35 insertions(+)
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index 58dd608..7bf86c8 100644
--- a/fs/f2fs/f2fs.h
+++ b/fs/f2fs/f2fs.h
@@ -104,6 +104,20 @@ static inline int update_sits_in_cursum(struct f2fs_summary_block *rs, int i)
}
/*
+ * ioctl commands
+ */
+#define F2FS_IOC_GETFLAGS FS_IOC_GETFLAGS
+#define F2FS_IOC_SETFLAGS FS_IOC_SETFLAGS
+
+#if defined(__KERNEL__) && defined(CONFIG_COMPAT)
+/*
+ * ioctl commands in 32 bit emulation
+ */
+#define F2FS_IOC32_GETFLAGS FS_IOC32_GETFLAGS
+#define F2FS_IOC32_SETFLAGS FS_IOC32_SETFLAGS
+#endif
+
+/*
* For INODE and NODE manager
*/
#define XATTR_NODE_OFFSET (-1) /*
@@ -850,6 +864,7 @@ void f2fs_truncate(struct inode *);
int f2fs_setattr(struct dentry *, struct iattr *);
int truncate_hole(struct inode *, pgoff_t, pgoff_t);
long f2fs_ioctl(struct file *, unsigned int, unsigned long);
+long f2fs_compat_ioctl(struct file *, unsigned int, unsigned long);
/*
* inode.c
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 633667e..e79d26a 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -644,6 +644,23 @@ out:
}
}
+#ifdef CONFIG_COMPAT
+long f2fs_compat_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
+{
+ switch (cmd) {
+ case F2FS_IOC32_GETFLAGS:
+ cmd = F2FS_IOC_GETFLAGS;
+ break;
+ case F2FS_IOC32_SETFLAGS:
+ cmd = F2FS_IOC_SETFLAGS;
+ break;
+ default:
+ return -ENOIOCTLCMD;
+ }
+ return f2fs_ioctl(file, cmd, (unsigned long) compat_ptr(arg));
+}
+#endif
+
const struct file_operations f2fs_file_operations = {
.llseek = generic_file_llseek,
.read = do_sync_read,
@@ -655,6 +672,9 @@ const struct file_operations f2fs_file_operations = {
.fsync = f2fs_sync_file,
.fallocate = f2fs_fallocate,
.unlocked_ioctl = f2fs_ioctl,
+#ifdef CONFIG_COMPAT
+ .compat_ioctl = f2fs_compat_ioctl,
+#endif
.splice_read = generic_file_splice_read,
.splice_write = generic_file_splice_write,
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] f2fs: add compat_ioctl to provide backward compatability
2013-02-04 14:41 [PATCH] f2fs: add compat_ioctl to provide backward compatability Namjae Jeon
@ 2013-02-05 5:28 ` Namjae Jeon
2013-02-05 6:45 ` Jaegeuk Kim
0 siblings, 1 reply; 6+ messages in thread
From: Namjae Jeon @ 2013-02-05 5:28 UTC (permalink / raw)
To: jaegeuk.kim
Cc: linux-fsdevel, linux-kernel, linux-f2fs-devel, Namjae Jeon,
Namjae Jeon, Amit Sahrawat
Hi Jaegeuk.
Oops!, I was missing include header.
Sorry, I will send v2 patch again.
Thanks.
2013/2/4, Namjae Jeon <linkinjeon@gmail.com>:
> From: Namjae Jeon <namjae.jeon@samsung.com>
>
> adding compat_ioctl to provide support for backward comptability - 32bit
> binary
> execution on 64bit kernel.
>
> Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> Signed-off-by: Amit Sahrawat <a.sahrawat@samsung.com>
> ---
> fs/f2fs/f2fs.h | 15 +++++++++++++++
> fs/f2fs/file.c | 20 ++++++++++++++++++++
> 2 files changed, 35 insertions(+)
>
> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
> index 58dd608..7bf86c8 100644
> --- a/fs/f2fs/f2fs.h
> +++ b/fs/f2fs/f2fs.h
> @@ -104,6 +104,20 @@ static inline int update_sits_in_cursum(struct
> f2fs_summary_block *rs, int i)
> }
>
> /*
> + * ioctl commands
> + */
> +#define F2FS_IOC_GETFLAGS FS_IOC_GETFLAGS
> +#define F2FS_IOC_SETFLAGS FS_IOC_SETFLAGS
> +
> +#if defined(__KERNEL__) && defined(CONFIG_COMPAT)
> +/*
> + * ioctl commands in 32 bit emulation
> + */
> +#define F2FS_IOC32_GETFLAGS FS_IOC32_GETFLAGS
> +#define F2FS_IOC32_SETFLAGS FS_IOC32_SETFLAGS
> +#endif
> +
> +/*
> * For INODE and NODE manager
> */
> #define XATTR_NODE_OFFSET (-1) /*
> @@ -850,6 +864,7 @@ void f2fs_truncate(struct inode *);
> int f2fs_setattr(struct dentry *, struct iattr *);
> int truncate_hole(struct inode *, pgoff_t, pgoff_t);
> long f2fs_ioctl(struct file *, unsigned int, unsigned long);
> +long f2fs_compat_ioctl(struct file *, unsigned int, unsigned long);
>
> /*
> * inode.c
> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> index 633667e..e79d26a 100644
> --- a/fs/f2fs/file.c
> +++ b/fs/f2fs/file.c
> @@ -644,6 +644,23 @@ out:
> }
> }
>
> +#ifdef CONFIG_COMPAT
> +long f2fs_compat_ioctl(struct file *file, unsigned int cmd, unsigned long
> arg)
> +{
> + switch (cmd) {
> + case F2FS_IOC32_GETFLAGS:
> + cmd = F2FS_IOC_GETFLAGS;
> + break;
> + case F2FS_IOC32_SETFLAGS:
> + cmd = F2FS_IOC_SETFLAGS;
> + break;
> + default:
> + return -ENOIOCTLCMD;
> + }
> + return f2fs_ioctl(file, cmd, (unsigned long) compat_ptr(arg));
> +}
> +#endif
> +
> const struct file_operations f2fs_file_operations = {
> .llseek = generic_file_llseek,
> .read = do_sync_read,
> @@ -655,6 +672,9 @@ const struct file_operations f2fs_file_operations = {
> .fsync = f2fs_sync_file,
> .fallocate = f2fs_fallocate,
> .unlocked_ioctl = f2fs_ioctl,
> +#ifdef CONFIG_COMPAT
> + .compat_ioctl = f2fs_compat_ioctl,
> +#endif
> .splice_read = generic_file_splice_read,
> .splice_write = generic_file_splice_write,
> };
> --
> 1.7.9.5
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] f2fs: add compat_ioctl to provide backward compatability
2013-02-05 5:28 ` Namjae Jeon
@ 2013-02-05 6:45 ` Jaegeuk Kim
2013-02-05 7:02 ` Namjae Jeon
0 siblings, 1 reply; 6+ messages in thread
From: Jaegeuk Kim @ 2013-02-05 6:45 UTC (permalink / raw)
To: Namjae Jeon
Cc: linux-fsdevel, linux-kernel, linux-f2fs-devel, Namjae Jeon,
Amit Sahrawat
[-- Attachment #1: Type: text/plain, Size: 3372 bytes --]
Hi,
2013-02-05 (화), 14:28 +0900, Namjae Jeon:
> Hi Jaegeuk.
>
> Oops!, I was missing include header.
> Sorry, I will send v2 patch again.
I got a build error, and simply added the following header file in your
patch.
#include <linux/compat.h>
Is it correct?
Thanks,
>
> Thanks.
>
> 2013/2/4, Namjae Jeon <linkinjeon@gmail.com>:
> > From: Namjae Jeon <namjae.jeon@samsung.com>
> >
> > adding compat_ioctl to provide support for backward comptability - 32bit
> > binary
> > execution on 64bit kernel.
> >
> > Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> > Signed-off-by: Amit Sahrawat <a.sahrawat@samsung.com>
> > ---
> > fs/f2fs/f2fs.h | 15 +++++++++++++++
> > fs/f2fs/file.c | 20 ++++++++++++++++++++
> > 2 files changed, 35 insertions(+)
> >
> > diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
> > index 58dd608..7bf86c8 100644
> > --- a/fs/f2fs/f2fs.h
> > +++ b/fs/f2fs/f2fs.h
> > @@ -104,6 +104,20 @@ static inline int update_sits_in_cursum(struct
> > f2fs_summary_block *rs, int i)
> > }
> >
> > /*
> > + * ioctl commands
> > + */
> > +#define F2FS_IOC_GETFLAGS FS_IOC_GETFLAGS
> > +#define F2FS_IOC_SETFLAGS FS_IOC_SETFLAGS
> > +
> > +#if defined(__KERNEL__) && defined(CONFIG_COMPAT)
> > +/*
> > + * ioctl commands in 32 bit emulation
> > + */
> > +#define F2FS_IOC32_GETFLAGS FS_IOC32_GETFLAGS
> > +#define F2FS_IOC32_SETFLAGS FS_IOC32_SETFLAGS
> > +#endif
> > +
> > +/*
> > * For INODE and NODE manager
> > */
> > #define XATTR_NODE_OFFSET (-1) /*
> > @@ -850,6 +864,7 @@ void f2fs_truncate(struct inode *);
> > int f2fs_setattr(struct dentry *, struct iattr *);
> > int truncate_hole(struct inode *, pgoff_t, pgoff_t);
> > long f2fs_ioctl(struct file *, unsigned int, unsigned long);
> > +long f2fs_compat_ioctl(struct file *, unsigned int, unsigned long);
> >
> > /*
> > * inode.c
> > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> > index 633667e..e79d26a 100644
> > --- a/fs/f2fs/file.c
> > +++ b/fs/f2fs/file.c
> > @@ -644,6 +644,23 @@ out:
> > }
> > }
> >
> > +#ifdef CONFIG_COMPAT
> > +long f2fs_compat_ioctl(struct file *file, unsigned int cmd, unsigned long
> > arg)
> > +{
> > + switch (cmd) {
> > + case F2FS_IOC32_GETFLAGS:
> > + cmd = F2FS_IOC_GETFLAGS;
> > + break;
> > + case F2FS_IOC32_SETFLAGS:
> > + cmd = F2FS_IOC_SETFLAGS;
> > + break;
> > + default:
> > + return -ENOIOCTLCMD;
> > + }
> > + return f2fs_ioctl(file, cmd, (unsigned long) compat_ptr(arg));
> > +}
> > +#endif
> > +
> > const struct file_operations f2fs_file_operations = {
> > .llseek = generic_file_llseek,
> > .read = do_sync_read,
> > @@ -655,6 +672,9 @@ const struct file_operations f2fs_file_operations = {
> > .fsync = f2fs_sync_file,
> > .fallocate = f2fs_fallocate,
> > .unlocked_ioctl = f2fs_ioctl,
> > +#ifdef CONFIG_COMPAT
> > + .compat_ioctl = f2fs_compat_ioctl,
> > +#endif
> > .splice_read = generic_file_splice_read,
> > .splice_write = generic_file_splice_write,
> > };
> > --
> > 1.7.9.5
> >
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Jaegeuk Kim
Samsung
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] f2fs: add compat_ioctl to provide backward compatability
2013-02-05 6:45 ` Jaegeuk Kim
@ 2013-02-05 7:02 ` Namjae Jeon
2013-02-05 7:12 ` Namjae Jeon
2013-02-05 7:12 ` Jaegeuk Kim
0 siblings, 2 replies; 6+ messages in thread
From: Namjae Jeon @ 2013-02-05 7:02 UTC (permalink / raw)
To: jaegeuk.kim
Cc: linux-fsdevel, linux-kernel, linux-f2fs-devel, Namjae Jeon,
Amit Sahrawat
2013/2/5, Jaegeuk Kim <jaegeuk.kim@samsung.com>:
> Hi,
>
> 2013-02-05 (화), 14:28 +0900, Namjae Jeon:
>> Hi Jaegeuk.
>>
>> Oops!, I was missing include header.
>> Sorry, I will send v2 patch again.
>
> I got a build error, and simply added the following header file in your
> patch.
>
> #include <linux/compat.h>
>
> Is it correct?
Yes, Right :) It should be needed.
Sorry for my mistake again. Could you add this header instead of me
?(because I can resend the patch tonight....).
Thanks!
>
> Thanks,
>
>>
>> Thanks.
>>
>> 2013/2/4, Namjae Jeon <linkinjeon@gmail.com>:
>> > From: Namjae Jeon <namjae.jeon@samsung.com>
>> >
>> > adding compat_ioctl to provide support for backward comptability -
>> > 32bit
>> > binary
>> > execution on 64bit kernel.
>> >
>> > Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
>> > Signed-off-by: Amit Sahrawat <a.sahrawat@samsung.com>
>> > ---
>> > fs/f2fs/f2fs.h | 15 +++++++++++++++
>> > fs/f2fs/file.c | 20 ++++++++++++++++++++
>> > 2 files changed, 35 insertions(+)
>> >
>> > diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
>> > index 58dd608..7bf86c8 100644
>> > --- a/fs/f2fs/f2fs.h
>> > +++ b/fs/f2fs/f2fs.h
>> > @@ -104,6 +104,20 @@ static inline int update_sits_in_cursum(struct
>> > f2fs_summary_block *rs, int i)
>> > }
>> >
>> > /*
>> > + * ioctl commands
>> > + */
>> > +#define F2FS_IOC_GETFLAGS FS_IOC_GETFLAGS
>> > +#define F2FS_IOC_SETFLAGS FS_IOC_SETFLAGS
>> > +
>> > +#if defined(__KERNEL__) && defined(CONFIG_COMPAT)
>> > +/*
>> > + * ioctl commands in 32 bit emulation
>> > + */
>> > +#define F2FS_IOC32_GETFLAGS FS_IOC32_GETFLAGS
>> > +#define F2FS_IOC32_SETFLAGS FS_IOC32_SETFLAGS
>> > +#endif
>> > +
>> > +/*
>> > * For INODE and NODE manager
>> > */
>> > #define XATTR_NODE_OFFSET (-1) /*
>> > @@ -850,6 +864,7 @@ void f2fs_truncate(struct inode *);
>> > int f2fs_setattr(struct dentry *, struct iattr *);
>> > int truncate_hole(struct inode *, pgoff_t, pgoff_t);
>> > long f2fs_ioctl(struct file *, unsigned int, unsigned long);
>> > +long f2fs_compat_ioctl(struct file *, unsigned int, unsigned long);
>> >
>> > /*
>> > * inode.c
>> > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
>> > index 633667e..e79d26a 100644
>> > --- a/fs/f2fs/file.c
>> > +++ b/fs/f2fs/file.c
>> > @@ -644,6 +644,23 @@ out:
>> > }
>> > }
>> >
>> > +#ifdef CONFIG_COMPAT
>> > +long f2fs_compat_ioctl(struct file *file, unsigned int cmd, unsigned
>> > long
>> > arg)
>> > +{
>> > + switch (cmd) {
>> > + case F2FS_IOC32_GETFLAGS:
>> > + cmd = F2FS_IOC_GETFLAGS;
>> > + break;
>> > + case F2FS_IOC32_SETFLAGS:
>> > + cmd = F2FS_IOC_SETFLAGS;
>> > + break;
>> > + default:
>> > + return -ENOIOCTLCMD;
>> > + }
>> > + return f2fs_ioctl(file, cmd, (unsigned long) compat_ptr(arg));
>> > +}
>> > +#endif
>> > +
>> > const struct file_operations f2fs_file_operations = {
>> > .llseek = generic_file_llseek,
>> > .read = do_sync_read,
>> > @@ -655,6 +672,9 @@ const struct file_operations f2fs_file_operations =
>> > {
>> > .fsync = f2fs_sync_file,
>> > .fallocate = f2fs_fallocate,
>> > .unlocked_ioctl = f2fs_ioctl,
>> > +#ifdef CONFIG_COMPAT
>> > + .compat_ioctl = f2fs_compat_ioctl,
>> > +#endif
>> > .splice_read = generic_file_splice_read,
>> > .splice_write = generic_file_splice_write,
>> > };
>> > --
>> > 1.7.9.5
>> >
>> >
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel"
>> in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> --
> Jaegeuk Kim
> Samsung
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] f2fs: add compat_ioctl to provide backward compatability
2013-02-05 7:02 ` Namjae Jeon
@ 2013-02-05 7:12 ` Namjae Jeon
2013-02-05 7:12 ` Jaegeuk Kim
1 sibling, 0 replies; 6+ messages in thread
From: Namjae Jeon @ 2013-02-05 7:12 UTC (permalink / raw)
To: jaegeuk.kim
Cc: linux-fsdevel, linux-kernel, linux-f2fs-devel, Namjae Jeon,
Amit Sahrawat
2013/2/5, Namjae Jeon <linkinjeon@gmail.com>:
> 2013/2/5, Jaegeuk Kim <jaegeuk.kim@samsung.com>:
>> Hi,
>>
>> 2013-02-05 (화), 14:28 +0900, Namjae Jeon:
>>> Hi Jaegeuk.
>>>
>>> Oops!, I was missing include header.
>>> Sorry, I will send v2 patch again.
>>
>> I got a build error, and simply added the following header file in your
>> patch.
>>
>> #include <linux/compat.h>
>>
>> Is it correct?
> Yes, Right :) It should be needed.
> Sorry for my mistake again. Could you add this header instead of me
> ?(because I can resend the patch tonight....).
>
> Thanks!
>>
>> Thanks,
>>
Hi Jaegeuk.
I tried to paste the patch in mail.
Could you take below patch instead of previous patch ?
Thanks.
--------------------------------------------------------------------------------------------------------
Subject: [PATCH] f2fs: add compat_ioctl to provide backward compatibility
From: Namjae Jeon <namjae.jeon@samsung.com>
adding compat_ioctl to provide support for backward comptability - 32bit binary
execution on 64bit kernel.
Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: Amit Sahrawat <a.sahrawat@samsung.com>
---
fs/f2fs/f2fs.h | 15 +++++++++++++++
fs/f2fs/file.c | 21 +++++++++++++++++++++
2 files changed, 36 insertions(+), 0 deletions(-)
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index 5022a7d..e980dd5 100644
--- a/fs/f2fs/f2fs.h
+++ b/fs/f2fs/f2fs.h
@@ -104,6 +104,20 @@ static inline int update_sits_in_cursum(struct
f2fs_summary_block *rs, int i)
}
/*
+ * ioctl commands
+ */
+#define F2FS_IOC_GETFLAGS FS_IOC_GETFLAGS
+#define F2FS_IOC_SETFLAGS FS_IOC_SETFLAGS
+
+#if defined(__KERNEL__) && defined(CONFIG_COMPAT)
+/*
+ * ioctl commands in 32 bit emulation
+ */
+#define F2FS_IOC32_GETFLAGS FS_IOC32_GETFLAGS
+#define F2FS_IOC32_SETFLAGS FS_IOC32_SETFLAGS
+#endif
+
+/*
* For INODE and NODE manager
*/
#define XATTR_NODE_OFFSET (-1) /*
@@ -842,6 +856,7 @@ void f2fs_truncate(struct inode *);
int f2fs_setattr(struct dentry *, struct iattr *);
int truncate_hole(struct inode *, pgoff_t, pgoff_t);
long f2fs_ioctl(struct file *, unsigned int, unsigned long);
+long f2fs_compat_ioctl(struct file *, unsigned int, unsigned long);
/*
* inode.c
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 33d1736..de3e533 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -17,6 +17,7 @@
#include <linux/types.h>
#include <linux/uaccess.h>
#include <linux/mount.h>
+#include <linux/compat.h>
#include "f2fs.h"
#include "node.h"
@@ -634,6 +635,23 @@ out:
}
}
+#ifdef CONFIG_COMPAT
+long f2fs_compat_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
+{
+ switch (cmd) {
+ case F2FS_IOC32_GETFLAGS:
+ cmd = F2FS_IOC_GETFLAGS;
+ break;
+ case F2FS_IOC32_SETFLAGS:
+ cmd = F2FS_IOC_SETFLAGS;
+ break;
+ default:
+ return -ENOIOCTLCMD;
+ }
+ return f2fs_ioctl(file, cmd, (unsigned long) compat_ptr(arg));
+}
+#endif
+
const struct file_operations f2fs_file_operations = {
.llseek = generic_file_llseek,
.read = do_sync_read,
@@ -645,6 +663,9 @@ const struct file_operations f2fs_file_operations = {
.fsync = f2fs_sync_file,
.fallocate = f2fs_fallocate,
.unlocked_ioctl = f2fs_ioctl,
+#ifdef CONFIG_COMPAT
+ .compat_ioctl = f2fs_compat_ioctl,
+#endif
.splice_read = generic_file_splice_read,
.splice_write = generic_file_splice_write,
};
--
1.7.2.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] f2fs: add compat_ioctl to provide backward compatability
2013-02-05 7:02 ` Namjae Jeon
2013-02-05 7:12 ` Namjae Jeon
@ 2013-02-05 7:12 ` Jaegeuk Kim
1 sibling, 0 replies; 6+ messages in thread
From: Jaegeuk Kim @ 2013-02-05 7:12 UTC (permalink / raw)
To: Namjae Jeon
Cc: linux-fsdevel, linux-kernel, linux-f2fs-devel, Namjae Jeon,
Amit Sahrawat
[-- Attachment #1: Type: text/plain, Size: 4330 bytes --]
2013-02-05 (화), 16:02 +0900, Namjae Jeon:
> 2013/2/5, Jaegeuk Kim <jaegeuk.kim@samsung.com>:
> > Hi,
> >
> > 2013-02-05 (화), 14:28 +0900, Namjae Jeon:
> >> Hi Jaegeuk.
> >>
> >> Oops!, I was missing include header.
> >> Sorry, I will send v2 patch again.
> >
> > I got a build error, and simply added the following header file in your
> > patch.
> >
> > #include <linux/compat.h>
> >
> > Is it correct?
> Yes, Right :) It should be needed.
> Sorry for my mistake again. Could you add this header instead of me
> ?(because I can resend the patch tonight....).
No problem. I've already done it. :)
Thanks,
>
> Thanks!
> >
> > Thanks,
> >
> >>
> >> Thanks.
> >>
> >> 2013/2/4, Namjae Jeon <linkinjeon@gmail.com>:
> >> > From: Namjae Jeon <namjae.jeon@samsung.com>
> >> >
> >> > adding compat_ioctl to provide support for backward comptability -
> >> > 32bit
> >> > binary
> >> > execution on 64bit kernel.
> >> >
> >> > Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> >> > Signed-off-by: Amit Sahrawat <a.sahrawat@samsung.com>
> >> > ---
> >> > fs/f2fs/f2fs.h | 15 +++++++++++++++
> >> > fs/f2fs/file.c | 20 ++++++++++++++++++++
> >> > 2 files changed, 35 insertions(+)
> >> >
> >> > diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
> >> > index 58dd608..7bf86c8 100644
> >> > --- a/fs/f2fs/f2fs.h
> >> > +++ b/fs/f2fs/f2fs.h
> >> > @@ -104,6 +104,20 @@ static inline int update_sits_in_cursum(struct
> >> > f2fs_summary_block *rs, int i)
> >> > }
> >> >
> >> > /*
> >> > + * ioctl commands
> >> > + */
> >> > +#define F2FS_IOC_GETFLAGS FS_IOC_GETFLAGS
> >> > +#define F2FS_IOC_SETFLAGS FS_IOC_SETFLAGS
> >> > +
> >> > +#if defined(__KERNEL__) && defined(CONFIG_COMPAT)
> >> > +/*
> >> > + * ioctl commands in 32 bit emulation
> >> > + */
> >> > +#define F2FS_IOC32_GETFLAGS FS_IOC32_GETFLAGS
> >> > +#define F2FS_IOC32_SETFLAGS FS_IOC32_SETFLAGS
> >> > +#endif
> >> > +
> >> > +/*
> >> > * For INODE and NODE manager
> >> > */
> >> > #define XATTR_NODE_OFFSET (-1) /*
> >> > @@ -850,6 +864,7 @@ void f2fs_truncate(struct inode *);
> >> > int f2fs_setattr(struct dentry *, struct iattr *);
> >> > int truncate_hole(struct inode *, pgoff_t, pgoff_t);
> >> > long f2fs_ioctl(struct file *, unsigned int, unsigned long);
> >> > +long f2fs_compat_ioctl(struct file *, unsigned int, unsigned long);
> >> >
> >> > /*
> >> > * inode.c
> >> > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> >> > index 633667e..e79d26a 100644
> >> > --- a/fs/f2fs/file.c
> >> > +++ b/fs/f2fs/file.c
> >> > @@ -644,6 +644,23 @@ out:
> >> > }
> >> > }
> >> >
> >> > +#ifdef CONFIG_COMPAT
> >> > +long f2fs_compat_ioctl(struct file *file, unsigned int cmd, unsigned
> >> > long
> >> > arg)
> >> > +{
> >> > + switch (cmd) {
> >> > + case F2FS_IOC32_GETFLAGS:
> >> > + cmd = F2FS_IOC_GETFLAGS;
> >> > + break;
> >> > + case F2FS_IOC32_SETFLAGS:
> >> > + cmd = F2FS_IOC_SETFLAGS;
> >> > + break;
> >> > + default:
> >> > + return -ENOIOCTLCMD;
> >> > + }
> >> > + return f2fs_ioctl(file, cmd, (unsigned long) compat_ptr(arg));
> >> > +}
> >> > +#endif
> >> > +
> >> > const struct file_operations f2fs_file_operations = {
> >> > .llseek = generic_file_llseek,
> >> > .read = do_sync_read,
> >> > @@ -655,6 +672,9 @@ const struct file_operations f2fs_file_operations =
> >> > {
> >> > .fsync = f2fs_sync_file,
> >> > .fallocate = f2fs_fallocate,
> >> > .unlocked_ioctl = f2fs_ioctl,
> >> > +#ifdef CONFIG_COMPAT
> >> > + .compat_ioctl = f2fs_compat_ioctl,
> >> > +#endif
> >> > .splice_read = generic_file_splice_read,
> >> > .splice_write = generic_file_splice_write,
> >> > };
> >> > --
> >> > 1.7.9.5
> >> >
> >> >
> >> --
> >> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel"
> >> in
> >> the body of a message to majordomo@vger.kernel.org
> >> More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
> > --
> > Jaegeuk Kim
> > Samsung
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Jaegeuk Kim
Samsung
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-02-05 7:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-04 14:41 [PATCH] f2fs: add compat_ioctl to provide backward compatability Namjae Jeon
2013-02-05 5:28 ` Namjae Jeon
2013-02-05 6:45 ` Jaegeuk Kim
2013-02-05 7:02 ` Namjae Jeon
2013-02-05 7:12 ` Namjae Jeon
2013-02-05 7:12 ` Jaegeuk Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).