From: Steven Whitehouse <swhiteho@redhat.com>
To: Lukas Czerner <lczerner@redhat.com>
Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
cluster-devel@redhat.com
Subject: Re: [Cluster-devel] [PATCH v2 08/18] gfs2: use ->invalidatepage() length argument
Date: Tue, 05 Feb 2013 09:47:39 +0000 [thread overview]
Message-ID: <1360057659.2717.14.camel@menhir> (raw)
In-Reply-To: <1360055531-26309-9-git-send-email-lczerner@redhat.com>
Hi,
Acked-by: Steven Whitehouse <swhiteho@redhat.com>
Steve.
On Tue, 2013-02-05 at 10:12 +0100, Lukas Czerner wrote:
> ->invalidatepage() aop now accepts range to invalidate so we can make
> use of it in gfs2_invalidatepage().
>
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
> Cc: cluster-devel@redhat.com
> ---
> fs/gfs2/aops.c | 9 +++++++--
> 1 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/fs/gfs2/aops.c b/fs/gfs2/aops.c
> index 5bd558c..3cf3dc8 100644
> --- a/fs/gfs2/aops.c
> +++ b/fs/gfs2/aops.c
> @@ -949,24 +949,29 @@ static void gfs2_invalidatepage(struct page *page, unsigned int offset,
> unsigned int length)
> {
> struct gfs2_sbd *sdp = GFS2_SB(page->mapping->host);
> + unsigned int stop = offset + length;
> + int partial_page = (offset || length < PAGE_CACHE_SIZE);
> struct buffer_head *bh, *head;
> unsigned long pos = 0;
>
> BUG_ON(!PageLocked(page));
> - if (offset == 0)
> + if (!partial_page)
> ClearPageChecked(page);
> if (!page_has_buffers(page))
> goto out;
>
> bh = head = page_buffers(page);
> do {
> + if (pos + bh->b_size > stop)
> + return;
> +
> if (offset <= pos)
> gfs2_discard(sdp, bh);
> pos += bh->b_size;
> bh = bh->b_this_page;
> } while (bh != head);
> out:
> - if (offset == 0)
> + if (!partial_page)
> try_to_release_page(page, 0);
> }
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-02-05 9:47 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-05 9:11 [PATCH v2 00/18] change invalidatepage prototype to accept length Lukas Czerner
2013-02-05 9:11 ` [PATCH v2 01/18] mm: " Lukas Czerner
2013-02-05 9:11 ` [PATCH v2 02/18] jbd2: change jbd2_journal_invalidatepage " Lukas Czerner
2013-02-05 9:11 ` [PATCH v2 03/18] ext4: use ->invalidatepage() length argument Lukas Czerner
2013-02-05 9:11 ` [PATCH v2 04/18] jbd: change journal_invalidatepage() to accept length Lukas Czerner
2013-02-05 9:11 ` [PATCH v2 05/18] xfs: use ->invalidatepage() length argument Lukas Czerner
2013-02-05 9:11 ` [PATCH v2 06/18] ocfs2: " Lukas Czerner
2013-02-05 9:12 ` [PATCH v2 07/18] ceph: " Lukas Czerner
2013-02-05 16:39 ` Sage Weil
2013-02-05 9:12 ` [PATCH v2 08/18] gfs2: " Lukas Czerner
2013-02-05 9:47 ` Steven Whitehouse [this message]
2013-02-05 9:12 ` [PATCH v2 09/18] reiserfs: " Lukas Czerner
2013-02-05 9:12 ` [PATCH v2 10/18] mm: teach truncate_inode_pages_range() to handle non page aligned ranges Lukas Czerner
2013-02-07 23:40 ` Andrew Morton
2013-02-08 9:08 ` Lukáš Czerner
2013-02-21 8:33 ` Lukáš Czerner
2013-02-21 21:49 ` Andrew Morton
2013-02-22 8:06 ` Lukáš Czerner
2013-02-05 9:12 ` [PATCH v2 11/18] Revert "ext4: remove no longer used functions in inode.c" Lukas Czerner
2013-02-05 9:12 ` [PATCH v2 12/18] Revert "ext4: fix fsx truncate failure" Lukas Czerner
2013-02-05 9:12 ` [PATCH v2 13/18] ext4: use ext4_zero_partial_blocks in punch_hole Lukas Czerner
2013-02-05 9:12 ` [PATCH v2 14/18] ext4: remove unused discard_partial_page_buffers Lukas Czerner
2013-02-05 9:12 ` [PATCH v2 15/18] ext4: remove unused code from ext4_remove_blocks() Lukas Czerner
2013-02-05 9:12 ` [PATCH v2 16/18] ext4: update ext4_ext_remove_space trace point Lukas Czerner
2013-02-05 9:12 ` [PATCH v2 17/18] ext4: make punch hole code path work with bigalloc Lukas Czerner
2013-02-05 9:12 ` [PATCH v2 18/18] ext4: Allow punch hole with bigalloc enabled Lukas Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360057659.2717.14.camel@menhir \
--to=swhiteho@redhat.com \
--cc=cluster-devel@redhat.com \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).