From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: [PATCH 1/3] udf: Fix bitmap overflow on large filesystems with small block size Date: Tue, 5 Feb 2013 15:40:21 +0100 Message-ID: <1360075223-9972-2-git-send-email-jack@suse.cz> References: <1360075223-9972-1-git-send-email-jack@suse.cz> Cc: Jan Kara To: linux-fsdevel@vger.kernel.org Return-path: Received: from cantor2.suse.de ([195.135.220.15]:53200 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755528Ab3BEOkh (ORCPT ); Tue, 5 Feb 2013 09:40:37 -0500 Received: from relay1.suse.de (unknown [195.135.220.254]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id 429E8A3DDF for ; Tue, 5 Feb 2013 15:40:36 +0100 (CET) In-Reply-To: <1360075223-9972-1-git-send-email-jack@suse.cz> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: For large UDF filesystems with 512-byte blocks the number of necessary bitmap blocks is larger than 2^16 so s_nr_groups in udf_bitmap overflows (the number will overflow for filesystems larger than 128 GB with 512-byte blocks). That results in ENOSPC errors despite the filesystem has plenty of free space. Fix the problem by changing s_nr_groups' type to 'int'. That is enough even for filesystems 2^32 blocks (UDF maximum) and 512-byte blocksize. Signed-off-by: Jan Kara --- fs/udf/udf_sb.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/udf/udf_sb.h b/fs/udf/udf_sb.h index 5f02722..8d1c9d4 100644 --- a/fs/udf/udf_sb.h +++ b/fs/udf/udf_sb.h @@ -82,7 +82,7 @@ struct udf_virtual_data { struct udf_bitmap { __u32 s_extLength; __u32 s_extPosition; - __u16 s_nr_groups; + int s_nr_groups; struct buffer_head **s_block_bitmap; }; -- 1.7.1