From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: [PATCH 2/3] udf: Make s_block_bitmap standard array Date: Tue, 5 Feb 2013 15:40:22 +0100 Message-ID: <1360075223-9972-3-git-send-email-jack@suse.cz> References: <1360075223-9972-1-git-send-email-jack@suse.cz> Cc: Jan Kara To: linux-fsdevel@vger.kernel.org Return-path: Received: from cantor2.suse.de ([195.135.220.15]:53202 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755556Ab3BEOkh (ORCPT ); Tue, 5 Feb 2013 09:40:37 -0500 Received: from relay2.suse.de (unknown [195.135.220.254]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id 4A145A41E0 for ; Tue, 5 Feb 2013 15:40:36 +0100 (CET) In-Reply-To: <1360075223-9972-1-git-send-email-jack@suse.cz> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: struct udf_bitmap has array of buffer pointers attached to it. The code unnecessarily used s_block_bitmap as a pointer to the array instead of the standard trick of using 0 length array in the declaration. Change that to make code more readable and actually shrink the structure by one pointer. Signed-off-by: Jan Kara --- fs/udf/super.c | 1 - fs/udf/udf_sb.h | 2 +- 2 files changed, 1 insertions(+), 2 deletions(-) diff --git a/fs/udf/super.c b/fs/udf/super.c index da8ce9f..f883080 100644 --- a/fs/udf/super.c +++ b/fs/udf/super.c @@ -1023,7 +1023,6 @@ static struct udf_bitmap *udf_sb_alloc_bitmap(struct super_block *sb, u32 index) if (bitmap == NULL) return NULL; - bitmap->s_block_bitmap = (struct buffer_head **)(bitmap + 1); bitmap->s_nr_groups = nr_groups; return bitmap; } diff --git a/fs/udf/udf_sb.h b/fs/udf/udf_sb.h index 8d1c9d4..4f7ddb7 100644 --- a/fs/udf/udf_sb.h +++ b/fs/udf/udf_sb.h @@ -83,7 +83,7 @@ struct udf_bitmap { __u32 s_extLength; __u32 s_extPosition; int s_nr_groups; - struct buffer_head **s_block_bitmap; + struct buffer_head *s_block_bitmap[0]; }; struct udf_part_map { -- 1.7.1