From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jaegeuk Kim <jaegeuk.kim@samsung.com>
Subject: Re: [PATCH 3/5] f2fs: move f2fs_balance_fs to correct place in unlink
Date: Sun, 03 Mar 2013 13:34:11 +0900
Message-ID: <1362285251.14386.10.camel@kjgkr>
References: <1362195663-20751-1-git-send-email-linkinjeon@gmail.com>
Reply-To: jaegeuk.kim@samsung.com
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature"; boundary="=-EJXP8Jo2BpI/fqYpnifs"
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	Namjae Jeon <namjae.jeon@samsung.com>,
	Amit Sahrawat <a.sahrawat@samsung.com>
To: Namjae Jeon <linkinjeon@gmail.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mailout4.samsung.com ([203.254.224.34]:33477 "EHLO
	mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752638Ab3CCEet (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Sat, 2 Mar 2013 23:34:49 -0500
In-reply-to: <1362195663-20751-1-git-send-email-linkinjeon@gmail.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>


--=-EJXP8Jo2BpI/fqYpnifs
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

2013-03-02 (=ED=86=A0), 12:41 +0900, Namjae Jeon:
> From: Namjae Jeon <namjae.jeon@samsung.com>
>=20
> Actual dirty of pages will occur in f2fs_delete_entry so move the
> f2fs_balance_fs just before deletion.
>=20
> Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> Signed-off-by: Amit Sahrawat <a.sahrawat@samsung.com>
> ---
>  fs/f2fs/namei.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c
> index 1a49b88..eaa86f5 100644
> --- a/fs/f2fs/namei.c
> +++ b/fs/f2fs/namei.c
> @@ -223,8 +223,6 @@ static int f2fs_unlink(struct inode *dir, struct dent=
ry *dentry)
>  	struct page *page;
>  	int err =3D -ENOENT;
> =20
> -	f2fs_balance_fs(sbi);
> -
>  	de =3D f2fs_find_entry(dir, &dentry->d_name, &page);
>  	if (!de)
>  		goto fail;
> @@ -236,6 +234,8 @@ static int f2fs_unlink(struct inode *dir, struct dent=
ry *dentry)
>  		goto fail;
>  	}
> =20
> +	f2fs_balance_fs(sbi);
> +

I think we don't need to do this because of no issues on performance and
reliability.
In addition, it would be better to call f2fs_balance_fs without any
dentry page.

>  	f2fs_delete_entry(de, page, inode);
> =20
>  	/* In order to evict this inode,  we set it dirty */

--=20
Jaegeuk Kim
Samsung

--=-EJXP8Jo2BpI/fqYpnifs
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAABAgAGBQJRMtLDAAoJEEAUqH6CSFDS778P/jjKoGf84ApyO/Db/3AAhT2s
t7NSizPyPFOohicSWMK0ylYCsFa60+OZc8HHJW5YQr0/jVnzKHMlJk1qf/plCjju
zC9CV83mVmvbvcmeFw3eC6K6kx/aDDMq8N1z8bQaAcznVsBdK0N/qhjWpQnHkEEP
WkkAyOwhlvpaNMrXlc7V2LXNb+Hh79VzUJawSZnBMlD+oDXDEKfwgz5g52q1Mh2l
XT5gAitRoIDKG7yKPadmTFx2MUJF75OyrHw6AIuKIhGm61IzMeIJ82kbB8+EU+hh
OTpoqzPcwrewccOmGDzkPS0ukONl4hCpV7Yk++7nxsk6WjCvHFxvo9n+aVNtcA0j
ovdRrj4CuESthxTFnufBVEe7OjyaCLtQgF9PNTvirp8KWA9mGOIxlXIQL+vdEqK/
NXaMVRPuUWCzO7uUxWPkUaIViLDeQbLoHY0lHZkeebd4R2D6PBBGg6YwB3fwqllM
OrF9AHXzuH91QRCEK8JDFDDYx+FG2S/s3u+VhYaMA1kIId6RunNyQFq0vC6IcrdU
bj8u4XfeWaoaASkFEB3wNZJP+QS/3GL1Hc5gvGBHHWBiPfbKMwlfNCXUQ6pB1cJT
fpjz8VohPvHQ9D9Mu8GKZnUoAQZXMtjAdLpv5z3aB4A47pmYvvu93I2B4Zj8iaN7
oODKioVaNOQ4O9VSJP1X
=U2du
-----END PGP SIGNATURE-----

--=-EJXP8Jo2BpI/fqYpnifs--