From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jaegeuk Kim Subject: Re: [PATCH 2/4] f2fs: do not skip writing file meta during fsync Date: Wed, 27 Mar 2013 09:18:33 +0900 Message-ID: <1364343513.29882.7.camel@kjgkr> References: <1364168414-12815-1-git-send-email-jaegeuk.kim@samsung.com> <1364168414-12815-2-git-send-email-jaegeuk.kim@samsung.com> Reply-To: jaegeuk.kim@samsung.com Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-RAHnHxpGeYgPh2Fbqe6a" Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net To: Namjae Jeon Return-path: Received: from mailout3.samsung.com ([203.254.224.33]:22087 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753430Ab3C0ATU (ORCPT ); Tue, 26 Mar 2013 20:19:20 -0400 In-reply-to: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: --=-RAHnHxpGeYgPh2Fbqe6a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable 2013-03-26 (=ED=99=94), 09:48 +0900, Namjae Jeon: > 2013/3/25, Jaegeuk Kim : > > This patch removes data_version check flow during the fsync call. > > The original purpose for the use of data_version was to avoid writng in= ode > > pages redundantly by the fsync calls repeatedly. > Hi Jaegeuk. > > However, when user can modify file meta and then call fsync, we should = not > > skip fsync procedure. > I have a question. > Which case does user can directly modify meta ? Recovery tool ? The meta means the inode information like atime, mtime, size, and so on, which can be modified by setattr() or something other vfs apis. Thanks, >=20 > Thanks. >=20 > > So, let's remove this condition check and hope that user triggers in ri= ght > > manner. > > > > Signed-off-by: Jaegeuk Kim > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" i= n > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ --=20 Jaegeuk Kim Samsung --=-RAHnHxpGeYgPh2Fbqe6a Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAABAgAGBQJRUjrZAAoJEEAUqH6CSFDSDssP+wcggqIsmwMt5QAo2GGaTKOA UopXmXFJ+CvgqE0a1vN93gH/BIhf/tnbU/ToH/IrtfbCpOxZ4KjoFIE36Y7NBYix abgFyRiCSBMePgscutQeRnSVzimr9JJhfY3Gz18lL8ZF1jN7JTYy8nQtZP0BrC7H JsaguK6wD2aNtEW9WtIvRK3HmCqR66dvM15eaclJ04BXD8/JLODnbGr3WpSqcqzn lBQUlQ/mMymDVNNap3cZpxBSgSynTVp7hBLLiiFxNMqlI666AbmFZ+MhhacT0A+U 2ufxkG6OCw8H/+kYEkyBDrgZaC6F37TTIlaiqoqt5HQwKIn+52B74RijMHWFn15Y VTWs47XZPmv578VZiiJVNiYaKdx8+Lf90lEGNk56zAtZP/NpK/XZhIdDyVwCh+s6 /NQdiMqmdtyZMLSZdjDJEnN/3QDC/MKiA5HtCcJssGHImfV9XkDSP+1/Kdu/Yv6e RpEyQzlXLOJ4l1y8V23dkMk57WfPJZzugdOIB3lVHHr3feqS6gOMgj6TUAdRwDcl k++8XD08lhWzUKeGIiq/xK73VFhUkRzO11P93JMJ7kCwzGyt3y62UkEnlPrxOzmW 9kMsO6K4/SdI55m3vWcJJ9nd2QosXRpd93FYZtZyG/UxxJBnTeYI39sCXnnAyySh 0OIdwC+6bcag00rkiJ34 =NLu6 -----END PGP SIGNATURE----- --=-RAHnHxpGeYgPh2Fbqe6a--