From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jaegeuk Kim Subject: Re: [PATCH 2/4] f2fs: do not skip writing file meta during fsync Date: Wed, 27 Mar 2013 10:18:48 +0900 Message-ID: <1364347128.29882.12.camel@kjgkr> References: <1364168414-12815-1-git-send-email-jaegeuk.kim@samsung.com> <1364168414-12815-2-git-send-email-jaegeuk.kim@samsung.com> <1364343513.29882.7.camel@kjgkr> Reply-To: jaegeuk.kim@samsung.com Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-OjnCZ5oB8NCi1mVAHI1j" Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net To: Namjae Jeon Return-path: In-reply-to: Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org --=-OjnCZ5oB8NCi1mVAHI1j Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable 2013-03-27 (=EC=88=98), 09:57 +0900, Namjae Jeon: > 2013/3/27, Jaegeuk Kim : > > 2013-03-26 (=ED=99=94), 09:48 +0900, Namjae Jeon: > >> 2013/3/25, Jaegeuk Kim : > >> > This patch removes data_version check flow during the fsync call. > >> > The original purpose for the use of data_version was to avoid writng > >> > inode > >> > pages redundantly by the fsync calls repeatedly. > >> Hi Jaegeuk. > >> > However, when user can modify file meta and then call fsync, we shou= ld > >> > not > >> > skip fsync procedure. > >> I have a question. > >> Which case does user can directly modify meta ? Recovery tool ? > > > > The meta means the inode information like atime, mtime, size, and so on= , > > which can be modified by setattr() or something other vfs apis. > > Thanks, > I understood. Thanks for your explanation :) > One more,, > When inode state is !(inode->i_state & I_DIRTY)), We don't need to skip = ? Even though fsync writes no data and the inode is clean, we should mark the inode to recover after power-off-recovery. Any data and its inode can be written to the disk clearly before fsync was called. Thanks, >=20 > Thanks. > > > >> > >> Thanks. > >> > >> > So, let's remove this condition check and hope that user triggers in > >> > right > >> > manner. > >> > > >> > Signed-off-by: Jaegeuk Kim > >> -- > >> To unsubscribe from this list: send the line "unsubscribe linux-kernel= " > >> in > >> the body of a message to majordomo@vger.kernel.org > >> More majordomo info at http://vger.kernel.org/majordomo-info.html > >> Please read the FAQ at http://www.tux.org/lkml/ > > > > -- > > Jaegeuk Kim > > Samsung > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" i= n > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ --=20 Jaegeuk Kim Samsung --=-OjnCZ5oB8NCi1mVAHI1j Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAABAgAGBQJRUkj4AAoJEEAUqH6CSFDSnRYP/ivPW8JXJ+Tv6GHKRFCceaGb pCkah7xGdfPtfqW8TZhSYvDUSjeus+7fQ1qCqw84pfB9zRAqCuBnLmruNUMqtBXS fAyAsMrZ1OqfX3WIjvt8GibdhuK0NehgmyssKx2PkCFPvraBrWoleXjnxBAwgIIU NNuvM+78atzLjxH1bitezZmJaIq5v2hse+NQU34FZ47s5K+uFkgqgnqrGStM5Wu7 m7CjPe1Dq70ue7zR3Lo/HZ+J733k23kKT7PUvdDQe4wyuWUY9xdcO1G8Ee2RMdWx f4X29GyafDZXFPzgKWkfLd07daDiYUQYAzPjGJNbqVjTHjFnZBFEv52PwqTioH5I I9ZfmMTwQ7srihMZhMlSYAwV0yPb9WHsDCcBRb2678LxTIF9Tto7Ee/kHEspW8QW m846PH3hRCVHv7ZXuLBcL5OYfTtOiaKB2/0lfU6zCh4TN1PEycMrT38zrG3Yem37 pGfMTW5YWn/Ue5GjpdLDc/gzMd8M6O/7+1lZfjh4Y/Z4//duavvSDz0z+XqszxdJ SJ4sWHQhV4d0k7ZLNRjiTdpWyTT445RkVKhkgXeQPTeKHoZfWalL412Ipdfk8Eg7 oyJ0UIKNZoUUQrF/MREZ4Xcy6vRA3EBjGeLZ1N2kj16LhaxcuSKk1VlUlkKXUkfd CEQoG3PCRiZmOFQlIgRZ =HJtZ -----END PGP SIGNATURE----- --=-OjnCZ5oB8NCi1mVAHI1j--