From mboxrd@z Thu Jan  1 00:00:00 1970
From: Joe Perches <joe@perches.com>
Subject: Re: [PATCH 2/2] hfsplus: add printk to log allocation failure in
 hfs_find_init()
Date: Sun, 07 Apr 2013 15:00:19 -0700
Message-ID: <1365372019.8922.17.camel@joe-AO722>
References: <0199BA74-9971-4928-A133-DB1FC562DC43@dubeyko.com>
	 <1365369695-8340-1-git-send-email-khoroshilov@ispras.ru>
	 <1365369695-8340-2-git-send-email-khoroshilov@ispras.ru>
Mime-Version: 1.0
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Cc: Vyacheslav Dubeyko <slava@dubeyko.com>,
	Hin-Tak Leung <htl10@users.sourceforge.net>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Artem Bityutskiy <artem.bityutskiy@linux.intel.com>,
	Christoph Hellwig <hch@lst.de>, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org
To: Alexey Khoroshilov <khoroshilov@ispras.ru>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <1365369695-8340-2-git-send-email-khoroshilov@ispras.ru>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Mon, 2013-04-08 at 01:21 +0400, Alexey Khoroshilov wrote:
> Add printk to log allocation failure in hfs_find_init(),
> "so that there is a sign in dmesg when the error condition is triggered".
> (per Hin-Tak Leung request)

Not needed.  There already is a generic dump_stack
on all allocation failures without __GFP_NOWARN.

> diff --git a/fs/hfsplus/bfind.c b/fs/hfsplus/bfind.c
[]
> @@ -18,8 +18,10 @@ int hfs_find_init(struct hfs_btree *tree, struct hfs_find_data *fd)

> +	if (!ptr) {
> +		printk(KERN_ERR "hfs: allocation failed in hfs_find_init()\n");
>  		return -ENOMEM;