From: Vyacheslav Dubeyko <slava@dubeyko.com>
To: Joe Perches <joe@perches.com>
Cc: Hin-Tak Leung <htl10@users.sourceforge.net>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] hfs/hfsplus: Modernize logging styles
Date: Tue, 09 Apr 2013 11:08:04 +0400 [thread overview]
Message-ID: <1365491284.2482.19.camel@slavad-ubuntu> (raw)
In-Reply-To: <cover.1365438493.git.joe@perches.com>
On Mon, 2013-04-08 at 09:37 -0700, Joe Perches wrote:
> Joe Perches (2):
> hfs/hfsplus: Convert dprint to hfs_dbg
> hfs/hfsplus: Convert printks to pr_<level>
>
Thank you for your efforts. It is a good work.
But I have some additional suggestions:
(1) I think that it makes sense to use no_printk() for the case when we
don't need in debug output.
(2) I think that it is really necessary to add info about file and line
number for the case of debug output.
As I know Hin Tak has some code for dynamic debugging. I think that it
is a time for publish this work also. But I suppose that we can have
opportunity to choose old-fashioned HFS debugging output or dynamic
debug by means of declaration of special macro definition for every
case. I mean constant for every case (static debug, dynamic debug, no
debug).
Thanks,
Vyacheslav Dubeyko.
> fs/hfs/bfind.c | 10 +++++----
> fs/hfs/bitmap.c | 4 ++--
> fs/hfs/bnode.c | 39 ++++++++++++++++++----------------
> fs/hfs/brec.c | 19 +++++++++--------
> fs/hfs/btree.c | 31 ++++++++++++++-------------
> fs/hfs/catalog.c | 12 ++++++-----
> fs/hfs/dir.c | 12 +++++------
> fs/hfs/extent.c | 20 ++++++++++--------
> fs/hfs/hfs_fs.h | 20 ++++++++++++++++--
> fs/hfs/inode.c | 4 ++--
> fs/hfs/mdb.c | 23 ++++++++++----------
> fs/hfs/super.c | 43 +++++++++++++++++++------------------
> fs/hfsplus/attributes.c | 26 +++++++++++------------
> fs/hfsplus/bfind.c | 6 +++---
> fs/hfsplus/bitmap.c | 12 +++++------
> fs/hfsplus/bnode.c | 36 +++++++++++++++----------------
> fs/hfsplus/brec.c | 14 ++++++-------
> fs/hfsplus/btree.c | 29 +++++++++++++------------
> fs/hfsplus/catalog.c | 11 +++++-----
> fs/hfsplus/dir.c | 14 ++++++-------
> fs/hfsplus/extents.c | 32 ++++++++++++++--------------
> fs/hfsplus/hfsplus_fs.h | 20 +++++++++++++++---
> fs/hfsplus/inode.c | 4 ++--
> fs/hfsplus/options.c | 22 +++++++++----------
> fs/hfsplus/super.c | 56 +++++++++++++++++++------------------------------
> fs/hfsplus/wrapper.c | 8 +++----
> fs/hfsplus/xattr.c | 41 ++++++++++++++++++------------------
> 27 files changed, 296 insertions(+), 272 deletions(-)
>
next prev parent reply other threads:[~2013-04-09 7:08 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-29 21:44 [PATCH] hfs: add error checking for hfs_find_init() Alexey Khoroshilov
2013-03-30 11:35 ` Vyacheslav Dubeyko
2013-03-30 14:01 ` Hin-Tak Leung
2013-04-06 21:13 ` Alexey Khoroshilov
2013-04-07 9:31 ` Vyacheslav Dubeyko
2013-04-07 21:21 ` [PATCH 1/2] hfsplus: add error propagation to __hfsplus_ext_write_extent() Alexey Khoroshilov
2013-04-07 21:21 ` [PATCH 2/2] hfsplus: add printk to log allocation failure in hfs_find_init() Alexey Khoroshilov
2013-04-07 22:00 ` Joe Perches
2013-04-08 6:08 ` Vyacheslav Dubeyko
2013-04-08 16:37 ` [PATCH 0/2] hfs/hfsplus: Modernize logging styles Joe Perches
2013-04-08 16:37 ` [PATCH 1/2] hfs/hfsplus: Convert dprint to hfs_dbg Joe Perches
2013-04-09 7:08 ` Vyacheslav Dubeyko
2013-04-15 0:53 ` Hin-Tak Leung
2013-04-15 1:51 ` Joe Perches
2013-04-15 1:56 ` Hin-Tak Leung
2013-04-15 2:06 ` Joe Perches
2013-04-15 3:46 ` Hin-Tak Leung
2013-04-15 4:00 ` Joe Perches
2013-04-15 4:22 ` Hin-Tak Leung
2013-04-15 4:38 ` Joe Perches
2013-04-08 16:37 ` [PATCH 2/2] hfs/hfsplus: Convert printks to pr_<level> Joe Perches
2013-04-09 7:08 ` Vyacheslav Dubeyko
2013-04-09 7:08 ` Vyacheslav Dubeyko [this message]
2013-04-09 10:39 ` [PATCH 0/2] hfs/hfsplus: Modernize logging styles Joe Perches
2013-04-09 11:06 ` Vyacheslav Dubeyko
2013-04-08 5:55 ` [PATCH 1/2] hfsplus: add error propagation to __hfsplus_ext_write_extent() Vyacheslav Dubeyko
2013-04-09 18:14 ` [PATCH 1/2] hfs: add error checking for hfs_find_init() Alexey Khoroshilov
2013-04-09 18:14 ` [PATCH 2/2] hfsplus: add error propagation to __hfsplus_ext_write_extent() Alexey Khoroshilov
2013-04-10 6:40 ` Vyacheslav Dubeyko
2013-04-10 6:40 ` [PATCH 1/2] hfs: add error checking for hfs_find_init() Vyacheslav Dubeyko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365491284.2482.19.camel@slavad-ubuntu \
--to=slava@dubeyko.com \
--cc=htl10@users.sourceforge.net \
--cc=joe@perches.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).