From: Vyacheslav Dubeyko <slava@dubeyko.com>
To: Joe Perches <joe@perches.com>
Cc: Hin-Tak Leung <htl10@users.sourceforge.net>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] hfs/hfsplus: Modernize logging styles
Date: Tue, 09 Apr 2013 15:06:20 +0400 [thread overview]
Message-ID: <1365505580.2482.35.camel@slavad-ubuntu> (raw)
In-Reply-To: <1365503985.6865.25.camel@joe-AO722>
On Tue, 2013-04-09 at 03:39 -0700, Joe Perches wrote:
> On Tue, 2013-04-09 at 11:08 +0400, Vyacheslav Dubeyko wrote:
> > On Mon, 2013-04-08 at 09:37 -0700, Joe Perches wrote:
> > > Joe Perches (2):
> > > hfs/hfsplus: Convert dprint to hfs_dbg
> > > hfs/hfsplus: Convert printks to pr_<level>
> []
> > But I have some additional suggestions:
> > (1) I think that it makes sense to use no_printk() for the case when we
> > don't need in debug output.
>
> I don't.
>
> no_printk is used simply to get gcc to verify
> format and args with __printf().
>
> The equivalent is already done by the
> if (DBG_##FLAG & DBG_MASK)
> printk(...)
> when DBG_MASK is 0
>
Ok. I agree.
> > (2) I think that it is really necessary to add info about file and line
> > number for the case of debug output.
>
> I don't. I think file/line is pretty useless.
>
I don't think so. Namely during debugging the file/line info is very
useful, from my point of view. So, I think that this adding makes sense.
> Adding dynamic_debug could be useful, but that's
> another patch.
>
> Also, checkpatch can be a useful tool, but all
> its warnings aren't necessary to always be fixed.
>
As I see, the goal of this patch set is overcome of checkpatch warnings.
I'd prefer not change the style of error messages in HFS/HFS+ drivers.
But this patch set makes sense because it fixes warnings of checkpatch
related to error messages.
Moreover, as I see the most of rest checkpatch's warnings makes sense
and it needs to be fixed, from my point of view.
> Also, please remember to trim your replies.
> It's not necessary to quote the entire email.
> Just quote the useful contextual bits.
> _Lots_ of people read this list and you can
> cause a lot to waste time looking for additional
> comments you don't make.
Sorry. It's my mistake.
With the best regards,
Vyacheslav Dubeyko.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2013-04-09 11:06 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-29 21:44 [PATCH] hfs: add error checking for hfs_find_init() Alexey Khoroshilov
2013-03-30 11:35 ` Vyacheslav Dubeyko
2013-03-30 14:01 ` Hin-Tak Leung
2013-04-06 21:13 ` Alexey Khoroshilov
2013-04-07 9:31 ` Vyacheslav Dubeyko
2013-04-07 21:21 ` [PATCH 1/2] hfsplus: add error propagation to __hfsplus_ext_write_extent() Alexey Khoroshilov
2013-04-07 21:21 ` [PATCH 2/2] hfsplus: add printk to log allocation failure in hfs_find_init() Alexey Khoroshilov
2013-04-07 22:00 ` Joe Perches
2013-04-08 6:08 ` Vyacheslav Dubeyko
2013-04-08 16:37 ` [PATCH 0/2] hfs/hfsplus: Modernize logging styles Joe Perches
2013-04-08 16:37 ` [PATCH 1/2] hfs/hfsplus: Convert dprint to hfs_dbg Joe Perches
2013-04-09 7:08 ` Vyacheslav Dubeyko
2013-04-15 0:53 ` Hin-Tak Leung
2013-04-15 1:51 ` Joe Perches
2013-04-15 1:56 ` Hin-Tak Leung
2013-04-15 2:06 ` Joe Perches
2013-04-15 3:46 ` Hin-Tak Leung
2013-04-15 4:00 ` Joe Perches
2013-04-15 4:22 ` Hin-Tak Leung
2013-04-15 4:38 ` Joe Perches
2013-04-08 16:37 ` [PATCH 2/2] hfs/hfsplus: Convert printks to pr_<level> Joe Perches
2013-04-09 7:08 ` Vyacheslav Dubeyko
2013-04-09 7:08 ` [PATCH 0/2] hfs/hfsplus: Modernize logging styles Vyacheslav Dubeyko
2013-04-09 10:39 ` Joe Perches
2013-04-09 11:06 ` Vyacheslav Dubeyko [this message]
2013-04-08 5:55 ` [PATCH 1/2] hfsplus: add error propagation to __hfsplus_ext_write_extent() Vyacheslav Dubeyko
2013-04-09 18:14 ` [PATCH 1/2] hfs: add error checking for hfs_find_init() Alexey Khoroshilov
2013-04-09 18:14 ` [PATCH 2/2] hfsplus: add error propagation to __hfsplus_ext_write_extent() Alexey Khoroshilov
2013-04-10 6:40 ` Vyacheslav Dubeyko
2013-04-10 6:40 ` [PATCH 1/2] hfs: add error checking for hfs_find_init() Vyacheslav Dubeyko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365505580.2482.35.camel@slavad-ubuntu \
--to=slava@dubeyko.com \
--cc=htl10@users.sourceforge.net \
--cc=joe@perches.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).