linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Xiaoli Feng <xifeng@redhat.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-fsdevel@vger.kernel.org, david@fromorbit.com,
	Xiaoli Feng <fengxiaoli0714@gmail.com>
Subject: Re: [PATCH v2] fs/stat: set attributes_mask for STATX_ATTR_DAX
Date: Wed, 25 Nov 2020 00:53:15 -0500 (EST)	[thread overview]
Message-ID: <136563737.59838105.1606283595257.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20201125024644.GA14534@magnolia>

Hi,

----- Original Message -----
> From: "Darrick J. Wong" <darrick.wong@oracle.com>
> To: "XiaoLi Feng" <xifeng@redhat.com>
> Cc: linux-fsdevel@vger.kernel.org, david@fromorbit.com, "Xiaoli Feng" <fengxiaoli0714@gmail.com>
> Sent: Wednesday, November 25, 2020 10:46:44 AM
> Subject: Re: [PATCH v2] fs/stat: set attributes_mask for STATX_ATTR_DAX
> 
> On Wed, Nov 25, 2020 at 10:08:40AM +0800, XiaoLi Feng wrote:
> > From: Xiaoli Feng <fengxiaoli0714@gmail.com>
> > 
> > keep attributes and attributes_mask are consistent for
> > STATX_ATTR_DAX.
> > ---
> > Hi,
> > Please help to review this patch. I send this patch because xfstests
> > generic/532
> > is failed for dax test.
> > 
> >  fs/stat.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/fs/stat.c b/fs/stat.c
> > index dacecdda2e79..4619b3fc9694 100644
> > --- a/fs/stat.c
> > +++ b/fs/stat.c
> > @@ -80,8 +80,10 @@ int vfs_getattr_nosec(const struct path *path, struct
> > kstat *stat,
> >  	if (IS_AUTOMOUNT(inode))
> >  		stat->attributes |= STATX_ATTR_AUTOMOUNT;
> >  
> > -	if (IS_DAX(inode))
> > +	if (IS_DAX(inode)) {
> >  		stat->attributes |= STATX_ATTR_DAX;
> > +		stat->attributes_mask |= STATX_ATTR_DAX;
> 
> From the discussion of the V1 patch:
> 
> Doesn't it make more sense for /filesystems/ driver to set the attr_mask
> bit when the filesystem is capable of DAX?  Surely we should be able to
> tell applications that DAX is a possibility for the fs even if it's not
> enabled on this specific file.
> 
> IOWs the place to make this change is in the ext2/ext4/fuse/xfs code,
> not in the generic vfs.

Got it. Thanks for review.

> 
> --D
> 
> > +	}
> >  
> >  	if (inode->i_op->getattr)
> >  		return inode->i_op->getattr(path, stat, request_mask,
> > --
> > 2.18.1
> > 
> 
> 


      reply	other threads:[~2020-11-25  5:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-25  2:08 [PATCH v2] fs/stat: set attributes_mask for STATX_ATTR_DAX XiaoLi Feng
2020-11-25  2:46 ` Darrick J. Wong
2020-11-25  5:53   ` Xiaoli Feng [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=136563737.59838105.1606283595257.JavaMail.zimbra@redhat.com \
    --to=xifeng@redhat.com \
    --cc=darrick.wong@oracle.com \
    --cc=david@fromorbit.com \
    --cc=fengxiaoli0714@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).