From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH 1/2] hfs/hfsplus: Convert dprint to hfs_dbg Date: Sun, 14 Apr 2013 18:51:14 -0700 Message-ID: <1365990674.1878.21.camel@joe-AO722> References: <1365987181.4850.YahooMailClassic@web172306.mail.ir2.yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: Vyacheslav Dubeyko , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: htl10@users.sourceforge.net Return-path: In-Reply-To: <1365987181.4850.YahooMailClassic@web172306.mail.ir2.yahoo.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Mon, 2013-04-15 at 01:53 +0100, Hin-Tak Leung wrote: > --- On Mon, 8/4/13, Joe Perches wrote: > > Use a more current logging style. [] > I have been sitting on a patch which changes this part of the code to dynamic debugging, and it is much simplier. Just: > #define dprint(flg, fmt, args...) \ > - if (flg & DBG_MASK) \ > - printk(fmt , ## args) > + pr_debug(fmt , ## args) This change wouldn't work well as it would make a mess of output that uses no prefix (ie: emits at KERN_DEFAULT) with output that uses KERN_DEBUG That's the reason for _dbg and _dbg_cont.